Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 22893048: file_manager: Split the open with browser stuff into a set of separate files (Closed)

Created:
7 years, 4 months ago by satorux1
Modified:
7 years, 4 months ago
Reviewers:
kinaba
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

file_manager: Split the open with browser stuff into a set of separate files Yet another meaty stuff from the kitchen sink file file_manager_util.cc BUG=270469 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219281

Patch Set 1 #

Total comments: 4

Patch Set 2 : address comments #

Messages

Total messages: 8 (0 generated)
satorux1
7 years, 4 months ago (2013-08-23 05:58:26 UTC) #1
kinaba
lgtm https://codereview.chromium.org/22893048/diff/1/chrome/browser/chromeos/extensions/file_manager/open_with_browser.h File chrome/browser/chromeos/extensions/file_manager/open_with_browser.h (right): https://codereview.chromium.org/22893048/diff/1/chrome/browser/chromeos/extensions/file_manager/open_with_browser.h#newcode5 chrome/browser/chromeos/extensions/file_manager/open_with_browser.h:5: // This file provides utilities for openinig files ...
7 years, 4 months ago (2013-08-23 06:51:55 UTC) #2
satorux1
https://codereview.chromium.org/22893048/diff/1/chrome/browser/chromeos/extensions/file_manager/open_with_browser.h File chrome/browser/chromeos/extensions/file_manager/open_with_browser.h (right): https://codereview.chromium.org/22893048/diff/1/chrome/browser/chromeos/extensions/file_manager/open_with_browser.h#newcode5 chrome/browser/chromeos/extensions/file_manager/open_with_browser.h:5: // This file provides utilities for openinig files with ...
7 years, 4 months ago (2013-08-23 08:22:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satorux@chromium.org/22893048/10001
7 years, 4 months ago (2013-08-23 08:26:32 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=71316
7 years, 4 months ago (2013-08-23 12:04:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satorux@chromium.org/22893048/10001
7 years, 4 months ago (2013-08-23 13:18:26 UTC) #6
commit-bot: I haz the power
Change committed as 219281
7 years, 4 months ago (2013-08-23 15:41:45 UTC) #7
satorux1
7 years, 4 months ago (2013-08-24 00:30:51 UTC) #8
Message was sent while issue was closed. 
Went through CQ but reverted as it broke the build...

http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2...

FAILED: g++ -MMD -MF
obj/chrome/browser/chromeos/extensions/file_manager/browser_chromeos.open_with_browser.o.d
-DANGLE_DX11 -D_FILE_OFFSET_BITS=64 -DCHROMIUM_BUILD -DCOMPONENT_BUILD
-DTOOLKIT_VIEWS=1 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_ASH=1
-DUSE_DEFAULT_RENDER_THEME=1 -DUSE_NSS=1 -DUSE_X11=1 -DOS_CHROMEOS=1
-DFILE_MANAGER_EXTENSION=1 -DIMAGE_LOADER_EXTENSION=1 -DENABLE_REMOTING=1
-DENABLE_WEBRTC=1 -DUSE_PROPRIETARY_CODECS -DENABLE_PEPPER_CDMS
-DENABLE_CONFIGURATION_POLICY -DENABLE_INPUT_SPEECH -DENABLE_NOTIFICATIONS
-DENABLE_HIDPI=1 -DENABLE_GPU=1 -DENABLE_EGLIMAGE=1 -DENABLE_TASK_MANAGER=1
-DENABLE_EXTENSIONS=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1
-DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1
-DENABLE_AUTOMATION=1 -DENABLE_GOOGLE_NOW=1 -DENABLE_FULL_PRINTING=1
-DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1
-DENABLE_APP_LIST=1 -DENABLE_MANAGED_USERS=1 -DENABLE_MDNS=1 -DNACL_WINDOWS=0
-DNACL_LINUX=1 -DNACL_OSX=0 -DNACL_TARGET_SUBARCH=64 -DNACL_TARGET_ARCH=x86
-DNACL_BUILD_SUBARCH=64 -DNACL_BUILD_ARCH=x86 -DGL_GLEXT_PROTOTYPES -DUSE_LIBGPS
-DLIBPEERCONNECTION_LIB=1 -DSKIA_DLL -DGR_DLL=1 -DSK_ENABLE_INST_COUNT=0
-DSK_SUPPORT_GPU=1 '-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"'
-DSK_USE_POSIX_THREADS -DSK_DEFERRED_CANVAS_USES_FACTORIES=1 -DHUNSPELL_STATIC
-DHUNSPELL_CHROME_CLIENT -DUSE_HUNSPELL -DU_USING_ICU_NAMESPACE=0
-DFEATURE_ENABLE_SSL -DFEATURE_ENABLE_VOICEMAIL -DEXPAT_RELATIVE_PATH
-DGTEST_RELATIVE_PATH -DJSONCPP_RELATIVE_PATH -DNO_MAIN_THREAD_WRAPPING
-DNO_SOUND_SYSTEM -DLINUX -DPOSIX -DCHROMEOS
-DI18N_PHONENUMBERS_USE_ICU_REGEXP=1 -DI18N_PHONENUMBERS_NO_THREAD_SAFETY=1
-DLIBXML_STATIC -DPROTOBUF_USE_DLLS -DGOOGLE_PROTOBUF_NO_RTTI
-DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DV8_SHARED -DUSING_V8_SHARED
-D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND
-DDYNAMIC_ANNOTATIONS_ENABLED=0 -D_FORTIFY_SOURCE=2 -Igen -I../../breakpad/src
-Iobj/chrome/browser_chromeos.gen -Iobj/chrome/browser_chromeos.gen/chrome
-I../.. -I../../third_party/khronos -I../../gpu -Igen/protoc_out -Igen/policy
-Igen/chrome -I../../net/third_party/nss/ssl -I../../third_party/skia/src/core
-I../../skia/config -I../../third_party/skia/include/config
-I../../third_party/skia/include/core -I../../third_party/skia/include/effects
-I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu
-I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops
-I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports
-I../../third_party/skia/include/utils -I../../skia/ext
-I../../third_party/cacheinvalidation/overrides
-I../../third_party/cacheinvalidation/src
-I../../third_party/cacheinvalidation/google/cacheinvalidation
-I../../third_party/icu/source/i18n -I../../third_party/icu/source/common
-I../../third_party/leveldatabase/src/include
-I../../third_party/leveldatabase/src -I../../third_party/leveldatabase
-I../../third_party/libjingle/overrides -I../../third_party/libjingle/source
-I../../testing/gtest/include -I../../third_party -I../../third_party/webrtc
-I../../third_party/jsoncpp/overrides/include
-I../../third_party/jsoncpp/source/include
-Igen/protoc_out/third_party/libphonenumber
-I../../third_party/libphonenumber/src -I../../third_party/libusb/src/libusb
-I../../third_party/libxml/linux/include -I../../third_party/libxml/src/include
-I../../third_party/npapi -I../../third_party/npapi/bindings
-I../../third_party/protobuf -I../../third_party/protobuf/src
-I../../third_party/re2 -I../../third_party/zlib -Igen/ui/app_locale_settings
-Igen/ui/ui_strings -Igen/ui/ui_resources -I../../v8/include -Igen/webkit
-Igen/ash/ash_resources -Igen/ash_strings -Igen/ui/gl
-I../../third_party/mesa/src/include -Werror -pthread -fno-exceptions
-fno-strict-aliasing -Wall -Wno-unused-parameter -Wno-missing-field-initializers
-fvisibility=hidden -pipe -fPIC -pthread -I/usr/include/glib-2.0
-I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/dbus-1.0
-I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -I/usr/include/nss
-I/usr/include/nspr -Wno-unknown-pragmas -O2 -fno-ident -fdata-sections
-ffunction-sections -fno-rtti -fno-threadsafe-statics
-fvisibility-inlines-hidden -Wsign-compare  -c
../../chrome/browser/chromeos/extensions/file_manager/open_with_browser.cc -o
obj/chrome/browser/chromeos/extensions/file_manager/browser_chromeos.open_with_browser.o
../../chrome/browser/chromeos/extensions/file_manager/open_with_browser.cc: In
function 'bool file_manager::util::OpenFileWithBrowser(Browser*, const
base::FilePath&)':
../../chrome/browser/chromeos/extensions/file_manager/open_with_browser.cc:186:63:
error: no matching function for call to
'PostTaskAndReplyWithResult(base::SequencedWorkerPool*,
tracked_objects::Location, base::Callback<GURL()>, base::Callback<void(const
GURL&)>)'
../../chrome/browser/chromeos/extensions/file_manager/open_with_browser.cc:186:63:
note: candidate is:
../../base/task_runner_util.h:55:6: note: template<class TaskReturnType, class
ReplyArgType> bool base::PostTaskAndReplyWithResult(base::TaskRunner*, const
tracked_objects::Location&, const base::Callback<TaskReturnType()>&, const
base::Callback<void(ReplyArgType)>&)
ninja: build stopped: subcommand failed.

Powered by Google App Engine
This is Rietveld 408576698