Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1332)

Unified Diff: chrome/browser/net/proxy_service_factory.cc

Issue 22893027: Temporarily disable v8 proxy resolver on win8 metro mode (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/net/proxy_service_factory.cc
diff --git a/chrome/browser/net/proxy_service_factory.cc b/chrome/browser/net/proxy_service_factory.cc
index bcae19410e6c9f5b6ac647c141892d1bdf4e91b1..66180e67037bfc33230a58028df6c142361223f7 100644
--- a/chrome/browser/net/proxy_service_factory.cc
+++ b/chrome/browser/net/proxy_service_factory.cc
@@ -25,6 +25,10 @@
#include "chromeos/network/dhcp_proxy_script_fetcher_chromeos.h"
#endif // defined(OS_CHROMEOS)
+#if defined(OS_WIN)
+#include "win8/util/win8_util.h"
+#endif
+
using content::BrowserThread;
// static
@@ -101,6 +105,12 @@ net::ProxyService* ProxyServiceFactory::CreateProxyService(
}
#endif // defined(OS_IOS)
+#if defined(OS_WIN)
+ // Crashes. http://crbug.com/266838
+ if (use_v8 && win8::IsSingleWindowMetroMode())
+ use_v8 = false;
+#endif
+
size_t num_pac_threads = 0u; // Use default number of threads.
// Check the command line for an override on the number of proxy resolver
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698