Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1195)

Unified Diff: Source/core/rendering/RenderBlockLineLayout.cpp

Issue 22893013: Move Floats out of RenderBlock (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix release bot compile error Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/rendering/RenderBlock.cpp ('k') | Source/core/rendering/RenderView.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderBlockLineLayout.cpp
diff --git a/Source/core/rendering/RenderBlockLineLayout.cpp b/Source/core/rendering/RenderBlockLineLayout.cpp
index 7bc7485b1b51a5d8ef5fbb74b6f5dc76e06797ed..0317ecf875e1fb5ef5e2d700a422304d73e3f0bc 100644
--- a/Source/core/rendering/RenderBlockLineLayout.cpp
+++ b/Source/core/rendering/RenderBlockLineLayout.cpp
@@ -112,7 +112,7 @@ public:
float availableWidth() const { return m_availableWidth; }
void updateAvailableWidth(LayoutUnit minimumHeight = 0);
- void shrinkAvailableWidthForNewFloatIfNeeded(RenderBlock::FloatingObject*);
+ void shrinkAvailableWidthForNewFloatIfNeeded(FloatingObject*);
void addUncommittedWidth(float delta) { m_uncommittedWidth += delta; }
void commit()
{
@@ -158,7 +158,7 @@ inline void LineWidth::updateAvailableWidth(LayoutUnit replacedHeight)
computeAvailableWidthFromLeftAndRight();
}
-inline void LineWidth::shrinkAvailableWidthForNewFloatIfNeeded(RenderBlock::FloatingObject* newFloat)
+inline void LineWidth::shrinkAvailableWidthForNewFloatIfNeeded(FloatingObject* newFloat)
{
LayoutUnit height = m_block->logicalHeight();
if (height < newFloat->logicalTop(m_block->isHorizontalWritingMode()) || height >= newFloat->logicalBottom(m_block->isHorizontalWritingMode()))
@@ -170,12 +170,12 @@ inline void LineWidth::shrinkAvailableWidthForNewFloatIfNeeded(RenderBlock::Floa
// based on the margin box. In order to do this, we need to walk back through the floating object list to find
// the first previous float that is on the same side as our newFloat.
ShapeOutsideInfo* previousShapeOutsideInfo = 0;
- const RenderBlock::FloatingObjectSet& floatingObjectSet = m_block->m_floatingObjects->set();
- RenderBlock::FloatingObjectSetIterator it = floatingObjectSet.end();
- RenderBlock::FloatingObjectSetIterator begin = floatingObjectSet.begin();
+ const FloatingObjectSet& floatingObjectSet = m_block->m_floatingObjects->set();
+ FloatingObjectSetIterator it = floatingObjectSet.end();
+ FloatingObjectSetIterator begin = floatingObjectSet.begin();
while (it != begin) {
--it;
- RenderBlock::FloatingObject* previousFloat = *it;
+ FloatingObject* previousFloat = *it;
if (previousFloat != newFloat && previousFloat->type() == newFloat->type()) {
previousShapeOutsideInfo = previousFloat->renderer()->shapeOutsideInfo();
if (previousShapeOutsideInfo) {
@@ -189,7 +189,7 @@ inline void LineWidth::shrinkAvailableWidthForNewFloatIfNeeded(RenderBlock::Floa
if (shapeOutsideInfo)
shapeOutsideInfo->computeSegmentsForContainingBlockLine(m_block->logicalHeight(), newFloat->logicalTop(m_block->isHorizontalWritingMode()), logicalHeightForLine(m_block, m_isFirstLine));
- if (newFloat->type() == RenderBlock::FloatingObject::FloatLeft) {
+ if (newFloat->type() == FloatingObject::FloatLeft) {
float newLeft = newFloat->logicalRight(m_block->isHorizontalWritingMode());
if (previousShapeOutsideInfo)
newLeft -= previousShapeOutsideInfo->rightSegmentMarginBoxDelta();
@@ -1443,8 +1443,8 @@ public:
RootInlineBox* endLine() const { return m_endLine; }
void setEndLine(RootInlineBox* line) { m_endLine = line; }
- RenderBlock::FloatingObject* lastFloat() const { return m_lastFloat; }
- void setLastFloat(RenderBlock::FloatingObject* lastFloat) { m_lastFloat = lastFloat; }
+ FloatingObject* lastFloat() const { return m_lastFloat; }
+ void setLastFloat(FloatingObject* lastFloat) { m_lastFloat = lastFloat; }
Vector<RenderBlock::FloatWithRect>& floats() { return m_floats; }
@@ -1459,7 +1459,7 @@ public:
private:
Vector<RenderBlock::FloatWithRect> m_floats;
- RenderBlock::FloatingObject* m_lastFloat;
+ FloatingObject* m_lastFloat;
RootInlineBox* m_endLine;
LineInfo m_lineInfo;
unsigned m_floatIndex;
« no previous file with comments | « Source/core/rendering/RenderBlock.cpp ('k') | Source/core/rendering/RenderView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698