Issue 22893003: Discard FileAPI pending operations on shutdown

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22893003: Discard FileAPI pending operations on shutdown (Closed)

Created:
7 years, 4 months ago by kinuko

Modified:
7 years, 4 months ago

Reviewers:
oshima, jam, tzik

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, kinuko+watch, jam, tzik+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Discard FileAPI pending operations on shutdown Making a few changes to try to discard more operations earlier. - Create SequencedTaskRunner with SKIP_ON_SHUTDOWN shutdown behavior - Call FileSystemContext::Shutdown when StoragePartitionImpl goes away to give earlier notice to discard inflight operations BUG=271903 TEST=tried a few manual shutdown tests with pending operations Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217488

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -1 line)			Patch
M	content/browser/fileapi/browser_file_system_helper.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	content/browser/storage_partition_impl.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	webkit/browser/fileapi/file_system_context.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	webkit/browser/fileapi/file_system_context.cc	View	1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

kinuko

I'm trying to reduce the # of tasks that may step in shutdown sequence. Can ...

7 years, 4 months ago (2013-08-13 08:46:52 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/22893003/1

7 years, 4 months ago (2013-08-14 02:37:47 UTC) #5

Message was sent while issue was closed.

Change committed as 217488

Expand Messages | Collapse Messages