Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 22891006: cc: Layer::SetTouchEventHandlerRegion should SetNeedsCommit (Closed)

Created:
7 years, 4 months ago by danakj
Modified:
7 years, 4 months ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

cc: Layer::SetTouchEventHandlerRegion should SetNeedsCommit Otherwise the new value is not going to get pushed to the impl side. R=enne BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218169

Patch Set 1 #

Patch Set 2 : toucheventhandlerregion: rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M cc/layers/layer.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/layers/layer_unittest.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
danakj
7 years, 4 months ago (2013-08-16 19:48:53 UTC) #1
enne (OOO)
lgtm
7 years, 4 months ago (2013-08-16 19:54:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/22891006/1
7 years, 4 months ago (2013-08-16 19:55:12 UTC) #3
commit-bot: I haz the power
Failed to apply patch for cc/layers/layer_unittest.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 4 months ago (2013-08-16 19:55:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/22891006/7001
7 years, 4 months ago (2013-08-16 21:32:57 UTC) #5
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=70828
7 years, 4 months ago (2013-08-16 22:57:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/22891006/7001
7 years, 4 months ago (2013-08-16 23:16:16 UTC) #7
commit-bot: I haz the power
7 years, 4 months ago (2013-08-17 13:42:45 UTC) #8
Message was sent while issue was closed.
Change committed as 218169

Powered by Google App Engine
This is Rietveld 408576698