Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 22888005: WheelEvent's deltaX/deltaY sign is wrong (Closed)

Created:
7 years, 4 months ago by do-not-use
Modified:
7 years, 4 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, Rick Byers
Visibility:
Public.

Description

WheelEvent's deltaX/deltaY sign is wrong According to the specification, if a user agent scrolls as the default action of the wheel event then the sign of the delta should be given by a right-hand coordinate system where positive X, Y, and Z axes are directed towards the right-most edge, bottom-most edge, and farthest depth (away from the user) of the document, respectively: http://www.w3.org/TR/DOM-Level-3-Events/#events-wheelevents This signs for deltaX/deltaY are the inversed compared to the legacy wheelDeltaX/wheelDeltaY. r156404 added support for DOM3 WheelEvent but used the same sign for deltaX/deltaY and wheelDeltaX/wheelDeltaY. Firefox 23 and IE10 uses the right sign according to the specification. BUG=227454 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156478

Patch Set 1 #

Patch Set 2 : Avoid negative zero value #

Total comments: 5

Patch Set 3 : Add comment #

Patch Set 4 : Fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -14 lines) Patch
M LayoutTests/fast/events/wheelevent-basic.html View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/WheelEvent.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/dom/WheelEvent.cpp View 1 2 3 4 chunks +14 lines, -6 lines 0 comments Download
M Source/core/html/shadow/SpinButtonElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
do-not-use
7 years, 4 months ago (2013-08-21 11:47:31 UTC) #1
arv (Not doing code reviews)
LGTM https://codereview.chromium.org/22888005/diff/4001/Source/core/dom/WheelEvent.cpp File Source/core/dom/WheelEvent.cpp (right): https://codereview.chromium.org/22888005/diff/4001/Source/core/dom/WheelEvent.cpp#newcode36 Source/core/dom/WheelEvent.cpp:36: return 0; Is it worth special casing 0? ...
7 years, 4 months ago (2013-08-21 14:19:23 UTC) #2
do-not-use
https://codereview.chromium.org/22888005/diff/4001/Source/core/dom/WheelEvent.cpp File Source/core/dom/WheelEvent.cpp (right): https://codereview.chromium.org/22888005/diff/4001/Source/core/dom/WheelEvent.cpp#newcode36 Source/core/dom/WheelEvent.cpp:36: return 0; On 2013/08/21 14:19:23, arv wrote: > Is ...
7 years, 4 months ago (2013-08-21 14:31:09 UTC) #3
arv (Not doing code reviews)
Still LGTM https://codereview.chromium.org/22888005/diff/4001/Source/core/dom/WheelEvent.cpp File Source/core/dom/WheelEvent.cpp (right): https://codereview.chromium.org/22888005/diff/4001/Source/core/dom/WheelEvent.cpp#newcode36 Source/core/dom/WheelEvent.cpp:36: return 0; On 2013/08/21 14:31:10, Christophe Dumez ...
7 years, 4 months ago (2013-08-21 14:52:30 UTC) #4
do-not-use
https://codereview.chromium.org/22888005/diff/4001/Source/core/dom/WheelEvent.cpp File Source/core/dom/WheelEvent.cpp (right): https://codereview.chromium.org/22888005/diff/4001/Source/core/dom/WheelEvent.cpp#newcode36 Source/core/dom/WheelEvent.cpp:36: return 0; On 2013/08/21 14:52:30, arv wrote: > On ...
7 years, 4 months ago (2013-08-21 15:00:36 UTC) #5
arv (Not doing code reviews)
https://codereview.chromium.org/22888005/diff/4001/Source/core/dom/WheelEvent.cpp File Source/core/dom/WheelEvent.cpp (right): https://codereview.chromium.org/22888005/diff/4001/Source/core/dom/WheelEvent.cpp#newcode36 Source/core/dom/WheelEvent.cpp:36: return 0; On 2013/08/21 15:00:36, Christophe Dumez wrote: > ...
7 years, 4 months ago (2013-08-21 15:02:53 UTC) #6
do-not-use
On 2013/08/21 15:02:53, arv wrote: > https://codereview.chromium.org/22888005/diff/4001/Source/core/dom/WheelEvent.cpp > File Source/core/dom/WheelEvent.cpp (right): > > https://codereview.chromium.org/22888005/diff/4001/Source/core/dom/WheelEvent.cpp#newcode36 > ...
7 years, 4 months ago (2013-08-21 15:05:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/22888005/18001
7 years, 4 months ago (2013-08-21 15:21:47 UTC) #8
commit-bot: I haz the power
7 years, 4 months ago (2013-08-21 17:03:05 UTC) #9
Message was sent while issue was closed.
Change committed as 156478

Powered by Google App Engine
This is Rietveld 408576698