Fixes a leak of WebRTCIdentityRequestHandle when WebRTCIdentityStoreBackend::FindIdentity returns f…

Fixes a leak of WebRTCIdentityRequestHandle when WebRTCIdentityStoreBackend::FindIdentity returns false.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217108

[James Hawkins, 2013-08-12 17:56:01]

Thanks for fixing this, Jiayang.

[Ami GONE FROM CHROMIUM, 2013-08-12 17:56:34]

LGTM

https://codereview.chromium.org/22888002/diff/3001/content/browser/media/webr...
File content/browser/media/webrtc_identity_store.cc (right):

https://codereview.chromium.org/22888002/diff/3001/content/browser/media/webr...
content/browser/media/webrtc_identity_store.cc:208: request =
new_request.release();
TBH I think the old code made it easier to see how no requests would be leaked
than the new code, but I don't feel strongly about it.

If you want to keep the new code I suggest you drop this use of |request| and
instead:
in_flight_requests_.push_back(new_request.release());

[jiayl, 2013-08-12 18:28:41]

On 2013/08/12 17:56:34, Ami Fischman wrote:
> LGTM
> 
>
https://codereview.chromium.org/22888002/diff/3001/content/browser/media/webr...
> File content/browser/media/webrtc_identity_store.cc (right):
> 
>
https://codereview.chromium.org/22888002/diff/3001/content/browser/media/webr...
> content/browser/media/webrtc_identity_store.cc:208: request =
> new_request.release();
> TBH I think the old code made it easier to see how no requests would be leaked
> than the new code, but I don't feel strongly about it.
> 
> If you want to keep the new code I suggest you drop this use of |request| and
> instead:
> in_flight_requests_.push_back(new_request.release());

OK, reverted that part to the old code.

[commit-bot: I haz the power, 2013-08-12 18:31:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jiayl@chromium.org/22888002/8001

[commit-bot: I haz the power, 2013-08-12 23:00:11]

Change committed as 217108