Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: tools/json_schema_compiler/util.cc

Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Removed C-style casts. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/json_schema_compiler/cc_generator.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/json_schema_compiler/util.cc
diff --git a/tools/json_schema_compiler/util.cc b/tools/json_schema_compiler/util.cc
index a4495090fa4b3d02a563f53e395dc0a64fa893a1..9fd471bbb8759e8dc6eeff8e35c12521fe75da18 100644
--- a/tools/json_schema_compiler/util.cc
+++ b/tools/json_schema_compiler/util.cc
@@ -45,19 +45,19 @@ bool GetItemFromList(const base::ListValue& from, int index,
}
void AddItemToList(const int from, base::ListValue* out) {
- out->Append(base::Value::CreateIntegerValue(from));
+ out->Append(new base::FundamentalValue(from));
}
void AddItemToList(const bool from, base::ListValue* out) {
- out->Append(base::Value::CreateBooleanValue(from));
+ out->Append(new base::FundamentalValue(from));
}
void AddItemToList(const double from, base::ListValue* out) {
- out->Append(base::Value::CreateDoubleValue(from));
+ out->Append(new base::FundamentalValue(from));
}
void AddItemToList(const std::string& from, base::ListValue* out) {
- out->Append(base::Value::CreateStringValue(from));
+ out->Append(new base::StringValue(from));
}
void AddItemToList(const linked_ptr<base::Value>& from,
« no previous file with comments | « tools/json_schema_compiler/cc_generator.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698