Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3067)

Unified Diff: chrome/browser/extensions/api/web_request/web_request_api_helpers.cc

Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Removed C-style casts. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/web_request/web_request_api_helpers.cc
diff --git a/chrome/browser/extensions/api/web_request/web_request_api_helpers.cc b/chrome/browser/extensions/api/web_request/web_request_api_helpers.cc
index 5c10c8d1c1fa0ec606427e8e7d2d9dc69dc2ef26..19638b75b524bc2ffe8e3fab886fed41edbf086b 100644
--- a/chrome/browser/extensions/api/web_request/web_request_api_helpers.cc
+++ b/chrome/browser/extensions/api/web_request/web_request_api_helpers.cc
@@ -224,7 +224,7 @@ Value* NetLogModificationCallback(
delta->modified_request_headers);
while (modification.GetNext()) {
std::string line = modification.name() + ": " + modification.value();
- modified_headers->Append(Value::CreateStringValue(line));
+ modified_headers->Append(new base::StringValue(line));
}
dict->Set("modified_headers", modified_headers);
@@ -233,7 +233,7 @@ Value* NetLogModificationCallback(
delta->deleted_request_headers.begin();
key != delta->deleted_request_headers.end();
++key) {
- deleted_headers->Append(Value::CreateStringValue(*key));
+ deleted_headers->Append(new base::StringValue(*key));
}
dict->Set("deleted_headers", deleted_headers);
return dict;
@@ -249,7 +249,7 @@ base::ListValue* StringToCharList(const std::string& s) {
base::ListValue* result = new base::ListValue;
for (size_t i = 0, n = s.size(); i < n; ++i) {
result->Append(
- Value::CreateIntegerValue(
+ new base::FundamentalValue(
*reinterpret_cast<const unsigned char*>(&s[i])));
}
return result;

Powered by Google App Engine
This is Rietveld 408576698