chrome/browser/extensions/api/web_request/upload_data_presenter.cc - Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_request/upload_data_presenter.cc

Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Removed C-style casts. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.cc ('k') | chrome/browser/extensions/api/web_request/upload_data_presenter_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_request/upload_data_presenter.cc

diff --git a/chrome/browser/extensions/api/web_request/upload_data_presenter.cc b/chrome/browser/extensions/api/web_request/upload_data_presenter.cc

index 8b340128304df2cbcfa20841cfad6300e1f83823..2870bc60324afe303637c963d227cc0c680b8f52 100644

--- a/chrome/browser/extensions/api/web_request/upload_data_presenter.cc

+++ b/chrome/browser/extensions/api/web_request/upload_data_presenter.cc

@@ -97,7 +97,7 @@ void RawDataPresenter::FeedNextBytes(const char* bytes, size_t size) {

void RawDataPresenter::FeedNextFile(const std::string& filename) {

// Insert the file path instead of the contents, which may be too large.

subtle::AppendKeyValuePair(keys::kRequestBodyRawFileKey,

- Value::CreateStringValue(filename),

+ new base::StringValue(filename),

list_.get());

}