Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1331)

Unified Diff: chrome/browser/extensions/api/storage/settings_frontend_unittest.cc

Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Removed C-style casts. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/storage/settings_frontend_unittest.cc
diff --git a/chrome/browser/extensions/api/storage/settings_frontend_unittest.cc b/chrome/browser/extensions/api/storage/settings_frontend_unittest.cc
index 55bbaeb8650266207002fc1c588866bdb6256015..9eb8e45860957ab0053274c53a26442572b2197b 100644
--- a/chrome/browser/extensions/api/storage/settings_frontend_unittest.cc
+++ b/chrome/browser/extensions/api/storage/settings_frontend_unittest.cc
@@ -35,7 +35,7 @@ scoped_ptr<Value> CreateKilobyte() {
for (int i = 0; i < 1024; ++i) {
kilobyte_string += "a";
}
- return scoped_ptr<Value>(Value::CreateStringValue(kilobyte_string));
+ return scoped_ptr<Value>(new base::StringValue(kilobyte_string));
}
// Creates a megabyte of data.
@@ -47,7 +47,7 @@ scoped_ptr<Value> CreateMegabyte() {
return scoped_ptr<Value>(megabyte);
}
-}
+} // namespace
class ExtensionSettingsFrontendTest : public testing::Test {
public:

Powered by Google App Engine
This is Rietveld 408576698