chrome/browser/extensions/api/font_settings/font_settings_api.cc - Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/font_settings/font_settings_api.cc

Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Removed C-style casts. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/file_system/file_system_api.cc ('k') | chrome/browser/extensions/api/identity/experimental_identity_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/font_settings/font_settings_api.cc

diff --git a/chrome/browser/extensions/api/font_settings/font_settings_api.cc b/chrome/browser/extensions/api/font_settings/font_settings_api.cc

index b5498a144ec0597bfd1e6810a7d14aaa508836c9..476adcb0398dc71a8c782059f5fb6b6f88776455 100644

--- a/chrome/browser/extensions/api/font_settings/font_settings_api.cc

+++ b/chrome/browser/extensions/api/font_settings/font_settings_api.cc

@@ -303,7 +303,7 @@ bool FontSettingsSetFontFunction::RunImpl() {

extension_id(),

pref_path.c_str(),

kExtensionPrefsScopeRegular,

- Value::CreateStringValue(params->details.font_id));

+ new base::StringValue(params->details.font_id));

return true;

}

@@ -343,8 +343,8 @@ bool FontSettingsGetFontListFunction::CopyFontsToResult(

}

base::DictionaryValue* font_name = new base::DictionaryValue();

- font_name->Set(kFontIdKey, Value::CreateStringValue(name));

- font_name->Set(kDisplayNameKey, Value::CreateStringValue(localized_name));

+ font_name->Set(kFontIdKey, new base::StringValue(name));

+ font_name->Set(kDisplayNameKey, new base::StringValue(localized_name));

result->Append(font_name);

}