Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 22882009: Flush the SimpleBackendImpl's SWP in tests. (Closed)

Created:
7 years, 4 months ago by earthdok
Modified:
7 years, 3 months ago
Reviewers:
gavinp
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org
Visibility:
Public.

Description

Flush the SimpleBackendImpl's SWP in tests. Fixes memory leaks. BUG=278187 R=gavinp Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220615

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M net/disk_cache/disk_cache_test_base.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/disk_cache/simple/simple_backend_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/disk_cache/simple/simple_backend_impl.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
earthdok
please take a look
7 years, 4 months ago (2013-08-23 15:04:08 UTC) #1
earthdok
ping?
7 years, 3 months ago (2013-08-29 17:03:09 UTC) #2
gavinp
lgtm
7 years, 3 months ago (2013-08-30 14:59:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/earthdok@chromium.org/22882009/1
7 years, 3 months ago (2013-08-30 15:05:07 UTC) #4
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 3 months ago (2013-08-30 15:10:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/earthdok@chromium.org/22882009/1
7 years, 3 months ago (2013-08-30 15:17:49 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-08-30 18:29:16 UTC) #7
Message was sent while issue was closed.
Change committed as 220615

Powered by Google App Engine
This is Rietveld 408576698