chrome/browser/ui/search/search_tab_helper.cc - Issue 22882007: Remove GetActiveEntry usage from chrome/browser/ui.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/search/search_tab_helper.cc

Issue 22882007: Remove GetActiveEntry usage from chrome/browser/ui. Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased on ToT. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/search/search_tab_helper.cc

diff --git a/chrome/browser/ui/search/search_tab_helper.cc b/chrome/browser/ui/search/search_tab_helper.cc

index 059090fcfcdab15bc412417d91b3d6b2076ada30..865fa3bdd7ba534243ebbe36c9f2de67428cfd63 100644

--- a/chrome/browser/ui/search/search_tab_helper.cc

+++ b/chrome/browser/ui/search/search_tab_helper.cc

@@ -288,7 +288,7 @@ void SearchTabHelper::DidNavigateMainFrame(

// also a race condition between this code and the page's SetTitle call which

// this rule avoids.

content::NavigationEntry* entry =

- web_contents_->GetController().GetActiveEntry();

+ web_contents_->GetController().GetVisibleEntry();

if (entry && entry->GetTitle().empty() &&

(entry->GetVirtualURL() == GURL(chrome::kChromeUINewTabURL) ||

chrome::NavEntryIsInstantNTP(web_contents_, entry))) {