Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 22880017: Fix creating a directory in the Save-as dialog. (Closed)

Created:
7 years, 4 months ago by mtomasz
Modified:
7 years, 4 months ago
Reviewers:
hirono
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, rginda+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Fix creating a directory in the Save-as dialog. This regression was caused since we were listening for commands on the dialog container only. In the save-as dialog, the new folder button is on the footer, which is not a child of the dialog container. This patch adds listening for the command on the footer. TEST=Tested manually. BUG=272765 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218255

Patch Set 1 #

Patch Set 2 : Fixed. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/file_manager_browsertest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/file_manager/css/file_manager.css View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/file_manager/js/file_manager.js View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/resources/file_manager/main.html View 2 chunks +4 lines, -2 lines 2 comments Download

Messages

Total messages: 7 (0 generated)
mtomasz
@hirono: PTAL. Thanks!
7 years, 4 months ago (2013-08-19 03:40:19 UTC) #1
hirono
Thank you! https://codereview.chromium.org/22880017/diff/3001/chrome/browser/resources/file_manager/main.html File chrome/browser/resources/file_manager/main.html (right): https://codereview.chromium.org/22880017/diff/3001/chrome/browser/resources/file_manager/main.html#newcode385 chrome/browser/resources/file_manager/main.html:385: <div class="dialog-footer progressable" tabindex="-1" Just curious, why ...
7 years, 4 months ago (2013-08-19 03:51:06 UTC) #2
mtomasz
https://codereview.chromium.org/22880017/diff/3001/chrome/browser/resources/file_manager/main.html File chrome/browser/resources/file_manager/main.html (right): https://codereview.chromium.org/22880017/diff/3001/chrome/browser/resources/file_manager/main.html#newcode385 chrome/browser/resources/file_manager/main.html:385: <div class="dialog-footer progressable" tabindex="-1" On 2013/08/19 03:51:06, hirono wrote: ...
7 years, 4 months ago (2013-08-19 03:53:35 UTC) #3
hirono
lgtm, Thanks!
7 years, 4 months ago (2013-08-19 04:02:57 UTC) #4
mtomasz
thx!
7 years, 4 months ago (2013-08-19 04:12:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/22880017/3001
7 years, 4 months ago (2013-08-19 04:12:17 UTC) #6
commit-bot: I haz the power
7 years, 4 months ago (2013-08-19 10:34:20 UTC) #7
Message was sent while issue was closed.
Change committed as 218255

Powered by Google App Engine
This is Rietveld 408576698