Android WebView: don't define sincos.

Android WebView: don't define sincos.

The WebView builds as part of the system, which has sincos in the
versions we support; don't define it in Chromium as this causes a linker
warning.

BUG=157326
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220071

[Torne, 2013-08-16 15:20:44]

Hi Brett, can you take a look?

[brettw, 2013-08-16 19:50:05]

https://codereview.chromium.org/22877016/diff/1/base/base.gypi
File base/base.gypi (right):

https://codereview.chromium.org/22877016/diff/1/base/base.gypi#newcode762
base/base.gypi:762: # WebView builds as part of the system which already has
sincos;
It sucks to have to define this thing as part of the build files. Is there no
existing define we can use to determine if we're building as part of the Android
system?

[Torne, 2013-08-19 10:25:49]

https://codereview.chromium.org/22877016/diff/1/base/base.gypi
File base/base.gypi (right):

https://codereview.chromium.org/22877016/diff/1/base/base.gypi#newcode762
base/base.gypi:762: # WebView builds as part of the system which already has
sincos;
On 2013/08/16 19:50:05, brettw wrote:
> It sucks to have to define this thing as part of the build files. Is there no
> existing define we can use to determine if we're building as part of the
Android
> system?

I intentionally haven't provided a global define for android_webview_build,
because we build the WebView code as part of the regular upstream Android build
as well (as a standalone apk for test purposes), and I don't want people to
accidentally #ifdef things that are intended to be WebView-specific because that
doesn't work, the code is only built once upstream.

There's one or two places that, like this, need to be different because of the
build environment differences, and right now we have site-specific defines for
them in this way.

So.. yeah, I've done it this way on purpose to make it hard for #ifdefs to
proliferate through the code. If you think that sucks, we could revisit this;
there's only a few occurrences, so it wouldn't be hard to change.

[brettw, 2013-08-21 21:57:29]

LGTM

[commit-bot: I haz the power, 2013-08-22 09:31:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/torne@chromium.org/22877016/1

[commit-bot: I haz the power, 2013-08-22 09:54:42]

Retried try job too often on android_clang_dbg for step(s) slave_steps
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...

[commit-bot: I haz the power, 2013-08-28 09:00:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/torne@chromium.org/22877016/1

[commit-bot: I haz the power, 2013-08-28 10:18:21]

Retried try job too often on android_clang_dbg for step(s) slave_steps
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...

[commit-bot: I haz the power, 2013-08-28 14:20:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/torne@chromium.org/22877016/51001

[commit-bot: I haz the power, 2013-08-28 19:41:53]

Change committed as 220071