Remove using the Shell desktop Window when we don't have an acceleated widget.

Remove using the Shell desktop Window when we don't have an acceleated widget.

For Windows Ash (metro mode) we did not had timely access to the
real window (aka 'core window') so to keep the compositor from CHECKIing
we gave the shell desktop Window when it wanted a window here

RootWindow::RootWindow(const CreateParams& params) {
  ...
  compositor_.reset(new ui::Compositor(this, host_->GetAcceleratedWidget())); 
 ...
}

This was called from:
ash::DisplayController::AddRootWindowForDisplay
ash::DisplayController::InitPrimaryDisplay
ash::Shell::Init

Because ash was always created. Later on when the viewer process had started
it sends an IPC back with the core window which set the real window with 

void ChromeMetroViewerProcessHost::OnSetTargetSurface(..) {
  scoped_refptr<AcceleratedPresenter> any_window =
      AcceleratedPresenter::GetForWindow(NULL);
  any_window->SetNewTargetWindow(hwnd);
  ....
}

All this hackery can go away because now Ash starts on demand
once the aforementioned IPC arrives.

BUG=none
TEST=chromes starts in metro mode.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220694

[cpu_(ooo_6.6-7.5), 2013-08-25 23:35:17]

See my comments below for interesting spots.

https://codereview.chromium.org/22876030/diff/1/ash/test/test_metro_viewer_pr...
File ash/test/test_metro_viewer_process_host.cc (left):

https://codereview.chromium.org/22876030/diff/1/ash/test/test_metro_viewer_pr...
ash/test/test_metro_viewer_process_host.cc:34: backing_surface_.reset(new
AcceleratedSurface(hwnd));
note that here I switched the order (see lines 34 and 39), I don't think it
matters though.

https://codereview.chromium.org/22876030/diff/1/ui/surface/accelerated_surfac...
File ui/surface/accelerated_surface_win.cc (left):

https://codereview.chromium.org/22876030/diff/1/ui/surface/accelerated_surfac...
ui/surface/accelerated_surface_win.cc:678: swap_chain_ = NULL;
the new code does not null the swap chain, is that bad?

[gab, 2013-08-26 19:46:03]

lgtm w/ comments below.

https://codereview.chromium.org/22876030/diff/1/ui/aura/remote_root_window_ho...
File ui/aura/remote_root_window_host_win.h (right):

https://codereview.chromium.org/22876030/diff/1/ui/aura/remote_root_window_ho...
ui/aura/remote_root_window_host_win.h:89: static RemoteRootWindowHostWin*
Instance();
Document that this will return a RemoteRootWindowHostWin with empty bounds if
Create() wasn't previously called.

https://codereview.chromium.org/22876030/diff/1/ui/aura/remote_root_window_ho...
ui/aura/remote_root_window_host_win.h:93: // The |host| can be used when we need
to send a message to it.
Add |remote_window| to this comment.

https://codereview.chromium.org/22876030/diff/1/ui/surface/accelerated_surfac...
File ui/surface/accelerated_surface_win.cc (left):

https://codereview.chromium.org/22876030/diff/1/ui/surface/accelerated_surfac...
ui/surface/accelerated_surface_win.cc:678: swap_chain_ = NULL;
On 2013/08/25 23:35:17, cpu wrote:
> the new code does not null the swap chain, is that bad?

no idea.... scott?

[cpu_(ooo_6.6-7.5), 2013-08-27 23:58:54]

Al, please take a look since you are owner in surface.

gab, changes done.

[apatrick_chromium, 2013-08-28 00:03:28]

lgtm

https://codereview.chromium.org/22876030/diff/1/ui/surface/accelerated_surfac...
File ui/surface/accelerated_surface_win.cc (left):

https://codereview.chromium.org/22876030/diff/1/ui/surface/accelerated_surfac...
ui/surface/accelerated_surface_win.cc:678: swap_chain_ = NULL;
On 2013/08/26 19:46:03, gab wrote:
> On 2013/08/25 23:35:17, cpu wrote:
> > the new code does not null the swap chain, is that bad?
> 
> no idea.... scott?

I think it's okay.

[sky, 2013-08-28 20:34:48]

Sorry, no idea either. I'm not familiar with this code.

[cpu_(ooo_6.6-7.5), 2013-08-29 02:30:45]

so should I commit?

[sky, 2013-08-29 15:41:06]

Al said its ok, so commit away. LGTM

[commit-bot: I haz the power, 2013-08-30 19:38:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cpu@chromium.org/22876030/30001

[commit-bot: I haz the power, 2013-08-30 23:35:32]

Change committed as 220694

[scottmg, 2013-09-03 16:08:56]

lgtm

https://codereview.chromium.org/22876030/diff/1/ui/surface/accelerated_surfac...
File ui/surface/accelerated_surface_win.cc (left):

https://codereview.chromium.org/22876030/diff/1/ui/surface/accelerated_surfac...
ui/surface/accelerated_surface_win.cc:678: swap_chain_ = NULL;
On 2013/08/25 23:35:17, cpu wrote:
> the new code does not null the swap chain, is that bad?

That was probably there to force the Present to create a new swapchain after the
window was changed (sort of behind its back). Since it's just getting the right
window via GetAcceleratedWidget now, should be OK.