content/browser/renderer_host/media/video_capture_manager_unittest.cc - Issue 22876027: Consolidate duplicated frame / capability structures in video_capture_types.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/media/video_capture_manager_unittest.cc

Issue 22876027: Consolidate duplicated frame / capability structures in video_capture_types.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased: changed media::VideoCaptureCapability::kI420 -> media::PIXEL_FORMAT_I420 etc. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/media/video_capture_manager.cc ('k') | content/browser/renderer_host/media/web_contents_video_capture_device.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/media/video_capture_manager_unittest.cc

diff --git a/content/browser/renderer_host/media/video_capture_manager_unittest.cc b/content/browser/renderer_host/media/video_capture_manager_unittest.cc

index 83c064655edb30fd1d8e20b894c3b4ce52f53a34..29570a00cfda1fc1df32911ca021014a0e3989f2 100644

--- a/content/browser/renderer_host/media/video_capture_manager_unittest.cc

+++ b/content/browser/renderer_host/media/video_capture_manager_unittest.cc

@@ -113,7 +113,7 @@ TEST_F(VideoCaptureManagerTest, CreateAndClose) {

capture_params.session_id = video_session_id;

capture_params.width = 320;

capture_params.height = 240;

- capture_params.frame_per_second = 30;

+ capture_params.frame_rate = 30;

vcm_->Start(capture_params, frame_observer_.get());

vcm_->Stop(video_session_id, base::Closure());

@@ -222,7 +222,7 @@ TEST_F(VideoCaptureManagerTest, StartUsingId) {

capture_params.session_id = VideoCaptureManager::kStartOpenSessionId;

capture_params.width = 320;

capture_params.height = 240;

- capture_params.frame_per_second = 30;

+ capture_params.frame_rate = 30;

// Start shall trigger the Open callback.

vcm_->Start(capture_params, frame_observer_.get());

@@ -256,7 +256,7 @@ TEST_F(VideoCaptureManagerTest, CloseWithoutStop) {

capture_params.session_id = video_session_id;

capture_params.width = 320;

capture_params.height = 240;

- capture_params.frame_per_second = 30;

+ capture_params.frame_rate = 30;

vcm_->Start(capture_params, frame_observer_.get());

// Close will stop the running device, an assert will be triggered in