Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: chrome/android/java/res/layout/multiline_spinner_item.xml

Issue 2287513002: [Payments] Show name and address when selecting a CC billing address. (Closed)
Patch Set: Fixed comment Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/layout/multiline_spinner_item.xml
diff --git a/chrome/android/java/res/layout/infobar_control_spinner_drop_down.xml b/chrome/android/java/res/layout/multiline_spinner_item.xml
similarity index 57%
copy from chrome/android/java/res/layout/infobar_control_spinner_drop_down.xml
copy to chrome/android/java/res/layout/multiline_spinner_item.xml
index 1b5222c14b983af66a51a1e4b1d69c38940073cd..2483c20700b24a366ba060badef32e94a367f6c1 100644
--- a/chrome/android/java/res/layout/infobar_control_spinner_drop_down.xml
+++ b/chrome/android/java/res/layout/multiline_spinner_item.xml
@@ -1,17 +1,14 @@
<?xml version="1.0" encoding="utf-8"?>
-
<!-- Copyright 2016 The Chromium Authors. All rights reserved.
+
gone 2016/08/29 18:00:35 Might as well just remove the newline here.
sebsg 2016/08/29 20:08:50 Done.
Use of this source code is governed by a BSD-style license that can be
found in the LICENSE file.
-->
<TextView xmlns:android="http://schemas.android.com/apk/res/android"
- android:id="@+id/control_spinner_drop_down"
+ style="?android:attr/spinnerItemStyle"
+ android:singleLine="false"
android:layout_width="match_parent"
android:layout_height="wrap_content"
- android:layout_marginTop="10dp"
- android:layout_marginBottom="10dp"
- android:background="?android:attr/selectableItemBackground"
- android:ellipsize="end"
- android:padding="10dp"
- android:singleLine="true" />
+ android:ellipsize="marquee"
gone 2016/08/29 18:00:35 Does marquee do anything in this case? It's marke
sebsg 2016/08/29 20:08:50 Done.
+ android:textAlignment="inherit"/>
gone 2016/08/29 18:00:35 space between " and />
sebsg 2016/08/29 20:08:50 Done.

Powered by Google App Engine
This is Rietveld 408576698