Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(983)

Unified Diff: cc/output/filter_operation.cc

Issue 22875045: cc: Remove unnecessary "default" cases from switch statements. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove changes to enums that require arraysize Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/output/filter_operation.cc
diff --git a/cc/output/filter_operation.cc b/cc/output/filter_operation.cc
index 6a778388ae5162ebe7a2ae6298414ff698ba7662..3870496992bad5aa291ae026711b33778d92a222 100644
--- a/cc/output/filter_operation.cc
+++ b/cc/output/filter_operation.cc
@@ -147,10 +147,9 @@ static FilterOperation CreateNoOpFilter(FilterOperation::FilterType type) {
return FilterOperation::CreateZoomFilter(1.f, 0);
case FilterOperation::SATURATING_BRIGHTNESS:
return FilterOperation::CreateSaturatingBrightnessFilter(0.f);
- default:
- NOTREACHED();
- return FilterOperation::CreateEmptyFilter();
}
+ NOTREACHED();
+ return FilterOperation::CreateEmptyFilter();
}
static float ClampAmountForFilterType(float amount,
@@ -173,10 +172,10 @@ static float ClampAmountForFilterType(float amount,
case FilterOperation::SATURATING_BRIGHTNESS:
return amount;
case FilterOperation::COLOR_MATRIX:
- default:
- NOTREACHED();
- return amount;
+ break;
danakj 2013/08/26 15:55:39 can you NOTREACHED() inside this case as well, jus
reveman 2013/08/26 17:16:57 Done.
}
+ NOTREACHED();
+ return amount;
}
// static

Powered by Google App Engine
This is Rietveld 408576698