Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Side by Side Diff: cc/animation/transform_operation.cc

Issue 22875045: cc: Remove unnecessary "default" cases from switch statements. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove changes to enums that require arraysize Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | cc/layers/picture_layer_impl.cc » ('j') | cc/output/filter_operation.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <algorithm> 5 #include <algorithm>
6 #include <cmath> 6 #include <cmath>
7 #include <limits> 7 #include <limits>
8 8
9 #include "cc/animation/transform_operation.h" 9 #include "cc/animation/transform_operation.h"
10 #include "ui/gfx/box_f.h" 10 #include "ui/gfx/box_f.h"
(...skipping 275 matching lines...) Expand 10 before | Expand all | Expand 10 after
286 } else if (!bounds_max.IsEmpty()) { 286 } else if (!bounds_max.IsEmpty()) {
287 UnionBoxWithZeroScale(&bounds_max); 287 UnionBoxWithZeroScale(&bounds_max);
288 *bounds = bounds_max; 288 *bounds = bounds_max;
289 } 289 }
290 290
291 return true; 291 return true;
292 } 292 }
293 case TransformOperation::TransformOperationIdentity: 293 case TransformOperation::TransformOperationIdentity:
294 *bounds = box; 294 *bounds = box;
295 return true; 295 return true;
296 default: 296 case TransformOperation::TransformOperationRotate:
297 return false; 297 case TransformOperation::TransformOperationSkew:
298 case TransformOperation::TransformOperationPerspective:
299 case TransformOperation::TransformOperationMatrix:
300 break;
danakj 2013/08/26 15:55:39 can you return false here and NOTREACHED() below?
reveman 2013/08/26 17:16:57 Done.
298 } 301 }
302 return false;
299 } 303 }
300 304
301 } // namespace cc 305 } // namespace cc
OLDNEW
« no previous file with comments | « no previous file | cc/layers/picture_layer_impl.cc » ('j') | cc/output/filter_operation.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698