Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 22875030: Run |demuxer_| related tasks in the media thread in GTV. (Closed)

Created:
7 years, 4 months ago by ycheo (away)
Modified:
7 years, 4 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Run |demuxer_| related tasks in the media thread in GTV. - We found that the reading from |demuxer_| and its read-callback loops run very slowly, in the heavy load situation in the render thread. to improve the response time of the readings, we run tasks related to |demuxer_| in the media thread. BUG=268208 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219225

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Rebased. #

Total comments: 2

Patch Set 5 : Addressed Aaron's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+276 lines, -91 lines) Patch
M content/renderer/media/android/media_source_delegate.h View 1 2 3 6 chunks +44 lines, -7 lines 0 comments Download
M content/renderer/media/android/media_source_delegate.cc View 1 2 3 4 26 chunks +224 lines, -83 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.h View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
ycheo (away)
I left media_weak_this_ in order that the code isn't full with some macro. But, if ...
7 years, 4 months ago (2013-08-21 13:15:39 UTC) #1
qinmin
lgtm
7 years, 4 months ago (2013-08-21 15:33:35 UTC) #2
ycheo (away)
@jochen, Could you check content/renderer/render_view_impl.cc?
7 years, 4 months ago (2013-08-22 09:58:23 UTC) #3
jochen (gone - plz use gerrit)
lgtm
7 years, 4 months ago (2013-08-22 10:01:06 UTC) #4
acolwell GONE FROM CHROMIUM
lgtm % comment. https://codereview.chromium.org/22875030/diff/9001/content/renderer/media/android/media_source_delegate.cc File content/renderer/media/android/media_source_delegate.cc (left): https://codereview.chromium.org/22875030/diff/9001/content/renderer/media/android/media_source_delegate.cc#oldcode43 content/renderer/media/android/media_source_delegate.cc:43: #define BIND_TO_RENDER_LOOP(function) \ Please restore this ...
7 years, 4 months ago (2013-08-23 00:41:59 UTC) #5
ycheo (away)
https://codereview.chromium.org/22875030/diff/9001/content/renderer/media/android/media_source_delegate.cc File content/renderer/media/android/media_source_delegate.cc (left): https://codereview.chromium.org/22875030/diff/9001/content/renderer/media/android/media_source_delegate.cc#oldcode43 content/renderer/media/android/media_source_delegate.cc:43: #define BIND_TO_RENDER_LOOP(function) \ On 2013/08/23 00:41:59, acolwell wrote: > ...
7 years, 4 months ago (2013-08-23 00:51:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ycheo@chromium.org/22875030/17001
7 years, 4 months ago (2013-08-23 00:53:31 UTC) #7
commit-bot: I haz the power
7 years, 4 months ago (2013-08-23 05:32:54 UTC) #8
Message was sent while issue was closed.
Change committed as 219225

Powered by Google App Engine
This is Rietveld 408576698