Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 22875025: base: Minor cleanups in icu_util.h (Closed)

Created:
7 years, 4 months ago by tfarina
Modified:
7 years, 4 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, sadrul, ben+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, erikwright+watch_chromium.org, jshin+watch_chromium.org
Visibility:
Public.

Description

base: Minor cleanups in icu_util.h - Move it into base::i18n namespace. That is the namespace that should be used there. - Consequently, rename the function to InitializeICU(). R=brettw@chromium.org TBR=ben,thestig,jam Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219164

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -16 lines) Patch
M ash/shell/shell_main_parts.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/shell_main_parts_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/icu_util.h View 1 chunk +5 lines, -3 lines 0 comments Download
M base/i18n/icu_util.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M base/test/test_suite.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/convert_dict/convert_dict.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/app/content_main_runner.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/tld_cleanup/tld_cleanup.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/bench/bench_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/demo/demo_main.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
tfarina
7 years, 4 months ago (2013-08-20 00:59:53 UTC) #1
brettw
lgtm
7 years, 4 months ago (2013-08-20 05:10:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/22875025/1
7 years, 4 months ago (2013-08-22 22:15:06 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=22029
7 years, 4 months ago (2013-08-22 22:37:41 UTC) #4
tfarina
TBRing the other owners for the api call updates.
7 years, 4 months ago (2013-08-22 22:46:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/22875025/1
7 years, 4 months ago (2013-08-22 22:47:09 UTC) #6
Lei Zhang
lgtm
7 years, 4 months ago (2013-08-22 22:48:02 UTC) #7
commit-bot: I haz the power
7 years, 4 months ago (2013-08-23 00:39:15 UTC) #8
Message was sent while issue was closed.
Change committed as 219164

Powered by Google App Engine
This is Rietveld 408576698