[Android] Allow more support for experimentation with SDK.

[Android] Allow more support for experimentation with SDK.

Rolls DEPS for android_tools to include:
  ceb64e7 Use android_sdk_root gyp variable for GCM.

And updates envsetup.sh to enable pre-set values for some SDK build
defines.

BUG=261717
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217288

[Isaac (away), 2013-08-13 02:19:54]

lgtm w/ some comments.

https://codereview.chromium.org/22873004/diff/1/build/android/envsetup_functi...
File build/android/envsetup_functions.sh (right):

https://codereview.chromium.org/22873004/diff/1/build/android/envsetup_functi...
build/android/envsetup_functions.sh:225: if [[ -z "${ANDROID_NDK_ROOT}" || ! -d
"${ANDROID_NDK_ROOT}" ]]; then
How about we remove the -d check (checks the variable points to a valid
directory)?  We could trust the caller to have a proper environment.

https://codereview.chromium.org/22873004/diff/1/build/android/envsetup_functi...
build/android/envsetup_functions.sh:228: if [[ -z "${ANDROID_SDK_VERSION}" ]];
then
technically quotes aren't needed in a double bracket test, but it's fine, and
matches the style of the file.

https://codereview.chromium.org/22873004/diff/1/build/android/envsetup_functi...
build/android/envsetup_functions.sh:233: ! -d
"${ANDROID_SDK_ROOT}/${sdk_suffix}" ]]; then
ditto on -d here

[Yaron, 2013-08-13 02:24:45]

Prefer to keep as-is for the reason listed

https://codereview.chromium.org/22873004/diff/1/build/android/envsetup_functi...
File build/android/envsetup_functions.sh (right):

https://codereview.chromium.org/22873004/diff/1/build/android/envsetup_functi...
build/android/envsetup_functions.sh:233: ! -d
"${ANDROID_SDK_ROOT}/${sdk_suffix}" ]]; then
On 2013/08/13 02:19:54, Isaac wrote:
> ditto on -d here

I actually like this. It helped me catch an issue where my custom SDK had a
slightly different folder structure.

[Yaron, 2013-08-13 02:24:54]

(thanks for quick review)

[commit-bot: I haz the power, 2013-08-13 17:44:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yfriedman@chromium.org/22873004/1

[commit-bot: I haz the power, 2013-08-13 17:52:10]

Change committed as 217288