Chromium Code Reviews Chromium Code Reviews
Issue
22870004:
On uninstall, delete shortcuts first, and then remove directory only if empty. (Closed)
DescriptionOn uninstall, delete shortcuts first, and then remove directory only if empty.
Previously, ShellUtil::RemoveShortcuts() simply wipes out the entire directory if |location| is SHORTCUT_LOCATION_START_MENU or SHORTCUT_LOCATION_APP_SHORTCUTS, for efficiency. But we're now writing code to migrate shortcuts on the self-destruct flow. In this case, wiping out the directory would destroy our results. Therefore the new logic for deletion of these directories are:
- Use same code to remove Chrome-specific shortcuts (this is what's done for other diretories, e.g., Start Menu).
- If the directory becomes empty, then remove it; otherwise do nothing.
The side effect is that if user creates any non-Chrome shortcuts in these directories, then these shortcuts (and the containing directory) will persist after Chrome uninstall. I think this is a pretty normal behavior.
BUG=235857
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217130
Patch Set 1 #
Total comments: 2
Patch Set 2 : Fixing comments. #Messages
Total messages: 5 (0 generated)
|
