Chromium Code Reviews Chromium Code Reviews
Issue
22867032:
Use Finch to compare the performances of CLD1 and CLD2 (Closed)
DescriptionSuppression the problems on the build bots: There were two reasons why that CL broke the build tree. One is the size bloating, which was solved by https://codereview.chromium.org/23460018. The other is compiling error on ARM, and this was also solved by updating CLD2 (https://chromiumcodereview.appspot.com/23606017/).
--
Use Finch to compare the performances of CLD1 and CLD2
Add a compile time constant CLD_VERSION, which indicates the version of CLD. If this is not define, Finch test to compare CLD1 and CLD2 is supposed to be used.
By this CL, each platform will have the below status:
Linux: Use both CLD1 and CLD2 (and use Finch).
Mac OS X: Use both CLD1 and CLD2 (and use Finch).
Windows: Use only CLD1 once because now CLD2 can't be compiled on Windows. After we can have CLD2 compiled on Windows, we will use CLD2 and Finch asap.
iOS: Still use only CLD1. (It's because it is hard to use both CLD1 and CLD2 on mobile platform because of the binary size impact.)
Android: Still use only CLD1. (The same reason as iOS)
So some platforms will have two CLD binaries, but this is temporal in the sense that we intend to use Finch only for Dev and Beta channel. Before releasing the stable Chromium version, we decide which version of CLD is adopted, make another CL to use only one CLD, and send a merge request. (Of course, we hope we will be able to adopt CLD2.)
BUG=240647
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221380
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221675
Patch Set 1 #Patch Set 2 : . #Patch Set 3 : Bug fix: remove dependencies to the files of CLD2 which include 'main' functions #Patch Set 4 : Bug fix: add '%' #Patch Set 5 : (rebasing) #Patch Set 6 : Bug fix: Android's 'check_webview_licenses' tries to check all third_party libraries' licenses, but… #Patch Set 7 : (rebasing) #Patch Set 8 : Stop using CLD2 on Windows once #
Total comments: 4
Patch Set 9 : nits: Modify README.chromium #Patch Set 10 : (rebasing) #Patch Set 11 : (rebasing) #
Messages
Total messages: 16 (0 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
