Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 22866026: Log exceptions that terminate CQ loop (Closed)

Created:
7 years, 3 months ago by Isaac (away)
Modified:
7 years, 3 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/commit-queue@master
Visibility:
Public.

Description

Log exceptions that terminate CQ loop CQ exceptions currently only print to the console and are eventually lost in scrollback. R=maruel@chromium.org BUG=239272 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=219632

Patch Set 1 #

Patch Set 2 : Fix tests with fake logger #

Total comments: 1

Patch Set 3 : stub using self.mock #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -33 lines) Patch
M commit_queue.py View 1 4 chunks +33 lines, -31 lines 0 comments Download
M tests/commit_queue_test.py View 1 2 4 chunks +22 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Isaac (away)
(will need some test expectation updates too)
7 years, 3 months ago (2013-08-26 17:44:01 UTC) #1
M-A Ruel
lgtm :)
7 years, 3 months ago (2013-08-26 17:45:04 UTC) #2
Isaac (away)
I had to do some refactoring to fix the tests -- could you take another ...
7 years, 3 months ago (2013-08-26 19:13:47 UTC) #3
M-A Ruel
https://codereview.chromium.org/22866026/diff/5001/tests/commit_queue_test.py File tests/commit_queue_test.py (right): https://codereview.chromium.org/22866026/diff/5001/tests/commit_queue_test.py#newcode78 tests/commit_queue_test.py:78: commit_queue.SetupLogging = lambda _: None self.mock(commit_queue, 'SetupLogging', lambda _: ...
7 years, 3 months ago (2013-08-26 19:23:39 UTC) #4
Isaac (away)
Addressed comments -- sending to CQ.
7 years, 3 months ago (2013-08-26 22:57:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ilevy@chromium.org/22866026/10001
7 years, 3 months ago (2013-08-26 22:57:29 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-08-26 22:57:53 UTC) #7
Message was sent while issue was closed.
Change committed as 219632

Powered by Google App Engine
This is Rietveld 408576698