Issue 22866026: Log exceptions that terminate CQ loop

Issue 22866026: Log exceptions that terminate CQ loop (Closed)

Created:
7 years, 3 months ago by Isaac (away)

Modified:
7 years, 3 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/commit-queue@master

Visibility:
Public.

More Reviews

Description

Log exceptions that terminate CQ loop CQ exceptions currently only print to the console and are eventually lost in scrollback. R=maruel@chromium.org BUG=239272 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=219632

Patch Set 2 : Fix tests with fake logger #

Total comments: 1

Patch Set 3 : stub using self.mock #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -33 lines)			Patch
	M	commit_queue.py	View	1	4 chunks	+33 lines, -31 lines	0 comments	Download
	M	tests/commit_queue_test.py	View	1 2	4 chunks	+22 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Isaac (away)

I had to do some refactoring to fix the tests -- could you take another ...

7 years, 3 months ago (2013-08-26 19:13:47 UTC) #3

M-A Ruel

https://codereview.chromium.org/22866026/diff/5001/tests/commit_queue_test.py File tests/commit_queue_test.py (right): https://codereview.chromium.org/22866026/diff/5001/tests/commit_queue_test.py#newcode78 tests/commit_queue_test.py:78: commit_queue.SetupLogging = lambda _: None self.mock(commit_queue, 'SetupLogging', lambda _: ...

7 years, 3 months ago (2013-08-26 19:23:39 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ilevy@chromium.org/22866026/10001

7 years, 3 months ago (2013-08-26 22:57:29 UTC) #6

Message was sent while issue was closed.

Change committed as 219632

Expand Messages | Collapse Messages