Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 22866002: Make xfermodes3 GM also test stroked rects (Closed)

Created:
7 years, 4 months ago by bsalomon
Modified:
7 years, 4 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Make xfermodes3 GM also test stroked rects Committed: http://code.google.com/p/skia/source/detail?r=10720

Patch Set 1 #

Total comments: 2

Patch Set 2 : int->size_t #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -34 lines) Patch
M gm/xfermodes3.cpp View 1 2 chunks +44 lines, -34 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bsalomon
Update xfermodes3 to draw stroked rects as well as fills.
7 years, 4 months ago (2013-08-12 18:19:06 UTC) #1
robertphillips
lgtm + 1 possible warning as error https://codereview.chromium.org/22866002/diff/1/gm/xfermodes3.cpp File gm/xfermodes3.cpp (right): https://codereview.chromium.org/22866002/diff/1/gm/xfermodes3.cpp#newcode68 gm/xfermodes3.cpp:68: }; size_t?
7 years, 4 months ago (2013-08-12 18:22:07 UTC) #2
bsalomon
int->size_t
7 years, 4 months ago (2013-08-12 18:26:47 UTC) #3
bsalomon
Will land once the tree is open and I'm prepared to rebaseline. https://codereview.chromium.org/22866002/diff/1/gm/xfermodes3.cpp File gm/xfermodes3.cpp ...
7 years, 4 months ago (2013-08-12 18:27:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/22866002/6001
7 years, 4 months ago (2013-08-14 18:24:15 UTC) #5
commit-bot: I haz the power
7 years, 4 months ago (2013-08-14 19:20:50 UTC) #6
Message was sent while issue was closed.
Change committed as 10720

Powered by Google App Engine
This is Rietveld 408576698