Add dependency on android_tools in java_apk.gypi for all test apks

Add dependency on android_tools in java_apk.gypi for all test apks.
    
This patch adds a dependency on entire android_tools target that contains
forwarder2 and md5sum to java_apk.gypi for all test apks, so that individual
test apk targets do not need to explicitly depend on the tools required to run
them.


BUG=271482
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217386

[ppi, 2013-08-12 15:57:35]

Could you guys have a look?

[jam, 2013-08-12 16:05:22]

rubberstamp lgtm (I don't know this, I'll defer to frankf)

[frankf, 2013-08-12 17:52:32]

Adding cjhopman, the resident build guru.

How about other instrumentation test targets (chromium_testshell_test_apk,
android_webview_test_apk, downstream)? 

It might make sense to factor this out into a common gypi such as apk_test.gypi
used for native. 

Also the comment in android_tools.gyp needs to be updated since it's not only
used for native tests.

[ppi, 2013-08-12 18:23:51]

Thanks, Frank, I updated the comment in patch set 2.

As to other instrumentation test targets:
- chromium_testshell_test_apk depends on forwarder, not forwarder2 (I don't know
the difference, but the former is not covered by android_tools)
- android_webview_test_apk does not seem to depend on either.
- downstream - there is a corresponding CL in review, I added you as reviewer.

Adding Jonathan - do we need md5sum and/or forwarder2 to run
android_webview_test_apk ?

[cjhopman, 2013-08-12 18:44:13]

On 2013/08/12 18:23:51, ppi wrote:
> Thanks, Frank, I updated the comment in patch set 2.
> 
> As to other instrumentation test targets:
> - chromium_testshell_test_apk depends on forwarder, not forwarder2 (I don't
know
> the difference, but the former is not covered by android_tools)
> - android_webview_test_apk does not seem to depend on either.
> - downstream - there is a corresponding CL in review, I added you as reviewer.
> 
> Adding Jonathan - do we need md5sum and/or forwarder2 to run
> android_webview_test_apk ?

I don't think we actually use forwarder anymore so the
chromium_testshell_test_apk dependency is probably wrong.

I think we should probably just add this as a dependency to all instrumentation
test apks. This can be done by moving it to a java_apk.gypi and guarding it by
an 'is_test_apk==1' condition.

[frankf, 2013-08-12 18:52:19]

On 2013/08/12 18:44:13, cjhopman wrote:
> On 2013/08/12 18:23:51, ppi wrote:
> > Thanks, Frank, I updated the comment in patch set 2.
> > 
> > As to other instrumentation test targets:
> > - chromium_testshell_test_apk depends on forwarder, not forwarder2 (I don't
> know
> > the difference, but the former is not covered by android_tools)
> > - android_webview_test_apk does not seem to depend on either.
> > - downstream - there is a corresponding CL in review, I added you as
reviewer.
> > 
> > Adding Jonathan - do we need md5sum and/or forwarder2 to run
> > android_webview_test_apk ?
> 
> I don't think we actually use forwarder anymore so the
> chromium_testshell_test_apk dependency is probably wrong.
> 
> I think we should probably just add this as a dependency to all
instrumentation
> test apks. This can be done by moving it to a java_apk.gypi and guarding it by
> an 'is_test_apk==1' condition.

@ppi: md5sum is needed by all test targets for pushing and installing apks.
Currently test scripts bring up forwarder for all
instrumentation tests, although it may not be used upstream currently.

[ppi, 2013-08-13 14:41:05]

Thanks a lot!

I moved the dependency to java_apk.gypi, as suggested by Chris, so that all test
apks are now covered.

Could you have another look?

[cjhopman, 2013-08-13 14:51:10]

lgtm

[frankf, 2013-08-13 17:45:09]

lgtm, thanks

[ppi, 2013-08-13 18:37:35]

Thanks!

[commit-bot: I haz the power, 2013-08-13 18:40:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ppi@chromium.org/22865003/12001

[commit-bot: I haz the power, 2013-08-13 23:46:50]

Change committed as 217386

[joth, 2013-08-17 03:35:36]

On 12 August 2013 11:23, <ppi@chromium.org> wrote:

> Thanks, Frank, I updated the comment in patch set 2.
>
> As to other instrumentation test targets:
> - chromium_testshell_test_apk depends on forwarder, not forwarder2 (I
> don't know
> the difference, but the former is not covered by android_tools)
> - android_webview_test_apk does not seem to depend on either.
> - downstream - there is a corresponding CL in review, I added you as
> reviewer.
>
> Adding Jonathan - do we need md5sum and/or forwarder2 to run
> android_webview_test_apk ?
>
> forwarder / forwarder2 are not actively needed by android_webview_test_apk
for successful execution on the device, however the shared test apk deploy
scripts expect forwarder2 to exist so we do have to build it (currently).

Afraid I don't know the scoop on md5sum other than it's in the default
build instructions so I guess was needed at some point at least.
(see go/clank/engineering/legacy-webview/android_webview-tests)