Issue 22861025: Get rid of ConvertFieldToDescriptor and simplify related code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22861025: Get rid of ConvertFieldToDescriptor and simplify related code. (Closed)

Created:
7 years, 4 months ago by Toon Verwaest

Modified:
7 years, 4 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Get rid of ConvertFieldToDescriptor and simplify related code. R=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16295

Patch Set 3 : Addressed comment and fixed cornercase #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+90 lines, -91 lines)			Patch
M	src/objects.h	View		5 chunks	+8 lines, -12 lines	0 comments	Download
M	src/objects.cc	View	1 2	12 chunks	+73 lines, -71 lines	0 comments	Download
M	src/objects-inl.h	View		2 chunks	+9 lines, -8 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

rossberg

LGTM, from what I could tell https://codereview.chromium.org/22861025/diff/6001/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/22861025/diff/6001/src/objects.cc#newcode4073 src/objects.cc:4073: break; Nit: I'd ...

7 years, 4 months ago (2013-08-23 09:24:13 UTC) #2

Toon Verwaest

PTAL again. I extracted the code into a separate static function, and made the interceptor ...

7 years, 4 months ago (2013-08-23 09:35:57 UTC) #3

rossberg

lgtm https://codereview.chromium.org/22861025/diff/16001/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/22861025/diff/16001/src/objects.cc#newcode4094 src/objects.cc:4094: result = ConvertSetLocalProperty(&lookup, *name, *value, attributes); Nit: ConvertAndSet...

7 years, 4 months ago (2013-08-23 09:51:42 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r16295.

Expand Messages | Collapse Messages

Issue 22861025: Get rid of ConvertFieldToDescriptor and simplify related code. (Closed)

Description

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : Addressed comment and fixed cornercase #

Messages