Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Unified Diff: net/disk_cache/simple/simple_synchronous_entry.h

Issue 22859060: Fix race condition for non-open/create operations happening after a doom. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/disk_cache/simple/simple_entry_operation.cc ('k') | net/disk_cache/simple/simple_synchronous_entry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/disk_cache/simple/simple_synchronous_entry.h
diff --git a/net/disk_cache/simple/simple_synchronous_entry.h b/net/disk_cache/simple/simple_synchronous_entry.h
index ae80681d429dbad1886bcf593ae562515595d408..f4b5ed81020538c9917f40db4d93a84f7e5d298f 100644
--- a/net/disk_cache/simple/simple_synchronous_entry.h
+++ b/net/disk_cache/simple/simple_synchronous_entry.h
@@ -85,14 +85,12 @@ class SimpleSynchronousEntry {
bool had_index,
SimpleEntryCreationResults* out_results);
- // Deletes an entry without first Opening it. Does not check if there is
- // already an Entry object in memory holding the open files. Be careful! This
- // is meant to be used by the Backend::DoomEntry() call. |callback| will be
- // run by |callback_runner|.
- static void DoomEntry(const base::FilePath& path,
- const std::string& key,
- uint64 entry_hash,
- int* out_result);
+ // Deletes an entry from the file system without affecting the state of the
+ // corresponding instance, if any (allowing operations to continue to be
+ // executed through that instance). Returns a net error code.
+ static int DoomEntry(const base::FilePath& path,
+ const std::string& key,
+ uint64 entry_hash);
// Like |DoomEntry()| above. Deletes all entries corresponding to the
// |key_hashes|. Succeeds only when all entries are deleted. Returns a net
« no previous file with comments | « net/disk_cache/simple/simple_entry_operation.cc ('k') | net/disk_cache/simple/simple_synchronous_entry.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698