Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Unified Diff: net/disk_cache/simple/simple_synchronous_entry.h

Issue 22859060: Fix race condition for non-open/create operations happening after a doom. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/disk_cache/simple/simple_synchronous_entry.h
diff --git a/net/disk_cache/simple/simple_synchronous_entry.h b/net/disk_cache/simple/simple_synchronous_entry.h
index f591c9a0f93ef026fcccf139da225b8495f9f369..58dc3dfc5a010e9380b3169aeb98d146e6232763 100644
--- a/net/disk_cache/simple/simple_synchronous_entry.h
+++ b/net/disk_cache/simple/simple_synchronous_entry.h
@@ -85,11 +85,10 @@ class SimpleSynchronousEntry {
// Deletes an entry without first Opening it. Does not check if there is
// already an Entry object in memory holding the open files. Be careful! This
// is meant to be used by the Backend::DoomEntry() call. |callback| will be
gavinp 2013/08/26 20:36:50 |callback| ?
Philippe 2013/08/27 11:33:30 Done.
- // run by |callback_runner|.
- static void DoomEntry(const base::FilePath& path,
+ // run by |callback_runner|. Returns a net error code.
+ static int DoomEntry(const base::FilePath& path,
const std::string& key,
- uint64 entry_hash,
- int* out_result);
+ uint64 entry_hash);
// Like |DoomEntry()| above. Deletes all entries corresponding to the
// |key_hashes|. Succeeds only when all entries are deleted. Returns a net

Powered by Google App Engine
This is Rietveld 408576698