net/disk_cache/simple/simple_entry_operation.h - Issue 22859060: Fix race condition for non-open/create operations happening after a doom.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/disk_cache/simple/simple_entry_operation.h

Issue 22859060: Fix race condition for non-open/create operations happening after a doom. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/disk_cache/simple/simple_entry_impl.cc ('K') | « net/disk_cache/simple/simple_entry_impl.cc ('k') | net/disk_cache/simple/simple_entry_operation.cc » ('j') | net/disk_cache/simple/simple_entry_operation.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/disk_cache/simple/simple_entry_operation.h

diff --git a/net/disk_cache/simple/simple_entry_operation.h b/net/disk_cache/simple/simple_entry_operation.h

index acdd60a3207e59324432e650e94a11905a930d0c..1c78701722924f243bdbf058f35e782437b5dd06 100644

--- a/net/disk_cache/simple/simple_entry_operation.h

+++ b/net/disk_cache/simple/simple_entry_operation.h

@@ -31,6 +31,7 @@ class SimpleEntryOperation {

TYPE_CLOSE = 2,

TYPE_READ = 3,

TYPE_WRITE = 4,

+ TYPE_DOOM = 5,

};

SimpleEntryOperation(const SimpleEntryOperation& other);

@@ -63,6 +64,10 @@ class SimpleEntryOperation {

bool optimistic,

const CompletionCallback& callback);

+ static SimpleEntryOperation DoomOperation(

+ SimpleEntryImpl* entry,

+ const CompletionCallback& callback);

bool ConflictsWith(const SimpleEntryOperation& other_op) const;

// Releases all references. After calling this operation, SimpleEntryOperation

// will only hold POD members.