Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 22859018: Added image and button to privet notification (Closed)

Created:
7 years, 4 months ago by Noam Samuel
Modified:
7 years, 3 months ago
CC:
chromium-reviews, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@privet_notifications4
Visibility:
Public.

Description

Added image and button to privet notification Added image to privet notification and button that goes to devices page. BUG=245385 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219645

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Updated to fix conflicts with master and remove binary files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -4 lines) Patch
M build/common.gypi View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/local_discovery/privet_notifications.h View 1 2 2 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/local_discovery/privet_notifications.cc View 1 2 4 chunks +50 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Noam Samuel
7 years, 4 months ago (2013-08-15 23:17:39 UTC) #1
Vitaly Buka (NO REVIEWS)
lgtm
7 years, 4 months ago (2013-08-16 18:17:18 UTC) #2
Vitaly Buka (NO REVIEWS)
BUG=?
7 years, 4 months ago (2013-08-16 18:19:14 UTC) #3
Noam Samuel
On 2013/08/16 18:19:14, Vitaly Buka wrote: > BUG=? Added BUG=
7 years, 4 months ago (2013-08-16 18:33:21 UTC) #4
Vitaly Buka (NO REVIEWS)
lgtm
7 years, 4 months ago (2013-08-16 18:33:42 UTC) #5
gene
lgtm
7 years, 4 months ago (2013-08-20 03:05:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/22859018/10001
7 years, 4 months ago (2013-08-22 22:30:36 UTC) #7
commit-bot: I haz the power
Can't process patch for file chrome/app/theme/default_200_percent/cloudprint.png. Binary file support is temporarilly disabled due to a ...
7 years, 4 months ago (2013-08-22 22:30:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/22859018/18001
7 years, 3 months ago (2013-08-26 18:45:10 UTC) #9
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=22399
7 years, 3 months ago (2013-08-26 19:14:28 UTC) #10
Noam Samuel
+oshima for theme resources
7 years, 3 months ago (2013-08-26 19:18:36 UTC) #11
oshima
c/a/theme lgtm
7 years, 3 months ago (2013-08-26 19:47:17 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/22859018/18001
7 years, 3 months ago (2013-08-26 20:38:02 UTC) #13
commit-bot: I haz the power
7 years, 3 months ago (2013-08-27 00:06:32 UTC) #14
Message was sent while issue was closed. 
Change committed as 219645

Powered by Google App Engine
This is Rietveld 408576698