Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: src/gpu/gl/GrGLCaps.cpp

Issue 22856006: Recognize that ES3 supports texture storage. Add workaround for apparent Adreno bug. (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/gpu/gl/GrGLInterface.cpp » ('j') | src/gpu/gl/GrGLInterface.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/gpu/gl/GrGLCaps.cpp
===================================================================
--- src/gpu/gl/GrGLCaps.cpp (revision 10811)
+++ src/gpu/gl/GrGLCaps.cpp (working copy)
@@ -159,11 +159,17 @@
fTextureUsageSupport = (kES_GrGLBinding == binding) &&
ctxInfo.hasExtension("GL_ANGLE_texture_usage");
- // Tex storage is in desktop 4.2 and can be an extension to desktop or ES.
- fTexStorageSupport = (kDesktop_GrGLBinding == binding &&
- version >= GR_GL_VER(4,2)) ||
- ctxInfo.hasExtension("GL_ARB_texture_storage") ||
- ctxInfo.hasExtension("GL_EXT_texture_storage");
+ if (kDesktop_GrGLBinding == binding) {
+ // The EXT version can apply to either GL or GLES.
+ fTexStorageSupport = version >= GR_GL_VER(4,2) ||
+ ctxInfo.hasExtension("GL_ARB_texture_storage") ||
+ ctxInfo.hasExtension("GL_EXT_texture_storage");
+ } else {
+ // Qualcomm Adreno drivers appear to have issues with texture storage.
+ fTexStorageSupport = (version >= GR_GL_VER(3,0) &&
+ kQualcomm_GrGLVendor != ctxInfo.vendor()) ||
+ ctxInfo.hasExtension("GL_EXT_texture_storage");
+ }
// ARB_texture_rg is part of OpenGL 3.0, but mesa doesn't support it if
// it doesn't have ARB_texture_rg extension.
« no previous file with comments | « no previous file | src/gpu/gl/GrGLInterface.cpp » ('j') | src/gpu/gl/GrGLInterface.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698