Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 22856006: Recognize that ES3 supports texture storage. Add workaround for apparent Adreno bug. (Closed)

Created:
7 years, 4 months ago by bsalomon
Modified:
7 years, 4 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Recognize that ES3 supports texture storage. Add workaround for apparent Adreno bug. Committed: http://code.google.com/p/skia/source/detail?r=10845

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -11 lines) Patch
M src/gpu/gl/GrGLCaps.cpp View 1 chunk +11 lines, -5 lines 0 comments Download
M src/gpu/gl/GrGLInterface.cpp View 1 chunk +1 line, -1 line 2 comments Download
M src/gpu/gl/GrGLUtil.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/GrGLUtil.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M src/gpu/gl/android/GrGLCreateNativeInterface_android.cpp View 3 chunks +20 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bsalomon
7 years, 4 months ago (2013-08-20 19:18:38 UTC) #1
robertphillips
lgtm + 1 question https://codereview.chromium.org/22856006/diff/1/src/gpu/gl/GrGLInterface.cpp File src/gpu/gl/GrGLInterface.cpp (right): https://codereview.chromium.org/22856006/diff/1/src/gpu/gl/GrGLInterface.cpp#newcode292 src/gpu/gl/GrGLInterface.cpp:292: } Don't we need the ...
7 years, 4 months ago (2013-08-21 12:56:48 UTC) #2
bsalomon
https://codereview.chromium.org/22856006/diff/1/src/gpu/gl/GrGLInterface.cpp File src/gpu/gl/GrGLInterface.cpp (right): https://codereview.chromium.org/22856006/diff/1/src/gpu/gl/GrGLInterface.cpp#newcode292 src/gpu/gl/GrGLInterface.cpp:292: } On 2013/08/21 12:56:48, robertphillips wrote: > Don't we ...
7 years, 4 months ago (2013-08-21 13:50:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/22856006/1
7 years, 4 months ago (2013-08-21 13:50:40 UTC) #4
commit-bot: I haz the power
7 years, 4 months ago (2013-08-21 14:02:16 UTC) #5
Message was sent while issue was closed.
Change committed as 10845

Powered by Google App Engine
This is Rietveld 408576698