Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 22856002: Add string for case when supervised user creation is disabled due to "only these users can log in" … (Closed)

Created:
7 years, 4 months ago by Denis Kuznetsov (DE-MUC)
Modified:
7 years, 4 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Add string for case when supervised user creation is disabled due to "only these users can log in" resitrictions. BUG=263610 TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217050

Patch Set 1 #

Total comments: 3

Patch Set 2 : Review fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -8 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_gaia_signin.html View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_gaia_signin.js View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 1 2 chunks +14 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Denis Kuznetsov (DE-MUC)
7 years, 4 months ago (2013-08-12 15:08:46 UTC) #1
Nikita (slow)
lgtm https://codereview.chromium.org/22856002/diff/1/chrome/app/chromeos_strings.grdp File chrome/app/chromeos_strings.grdp (right): https://codereview.chromium.org/22856002/diff/1/chrome/app/chromeos_strings.grdp#newcode474 chrome/app/chromeos_strings.grdp:474: <message name="IDS_CREATE_LOCALLY_MANAGED_USER_CREATION_RESTRICTED_TEXT" desc="Text shown when supervised user can ...
7 years, 4 months ago (2013-08-12 15:20:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/antrim@chromium.org/22856002/6001
7 years, 4 months ago (2013-08-12 16:12:08 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-08-12 19:21:24 UTC) #4
Message was sent while issue was closed.
Change committed as 217050

Powered by Google App Engine
This is Rietveld 408576698