Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 22854011: Store doubles before calling into the elements transition stub on ARM (Closed)

Created:
7 years, 4 months ago by Toon Verwaest
Modified:
7 years, 4 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Store doubles before calling into the elements transition stub on ARM BUG= R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16172

Patch Set 1 #

Patch Set 2 : Add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -9 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 chunk +3 lines, -2 lines 0 comments Download
A + test/mjsunit/regress/regress-et-clobbers-doubles.js View 1 1 chunk +10 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
7 years, 4 months ago (2013-08-13 15:03:33 UTC) #1
ulan
lgtm
7 years, 4 months ago (2013-08-13 15:04:35 UTC) #2
Toon Verwaest
7 years, 4 months ago (2013-08-13 15:06:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r16172.

Powered by Google App Engine
This is Rietveld 408576698