Issue 22852029: Add testRunner.cancelAllActiveNotifications to close all active notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22852029: Add testRunner.cancelAllActiveNotifications to close all active notifications. (Closed)

Created:
7 years, 4 months ago by kouhei (in TOK)

Modified:
7 years, 4 months ago

Reviewers:
haraken

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Add testRunner.cancelAllActiveNotifications to cancel all active notifications. This is to be used from automated GC leak testing to avoid false-positives from documents referenced from un-closed notifications. BUG=270000 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156684

Patch Set 1 #

Patch Set 2 : rename #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -0 lines)			Patch
M	Source/testing/runner/NotificationPresenter.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	Source/testing/runner/NotificationPresenter.cpp	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
M	Source/testing/runner/TestRunner.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/testing/runner/TestRunner.cpp	View	1	2 chunks	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kouhei (in TOK)

On 2013/08/26 02:08:33, haraken wrote: > LGTM Thanks for the review!

7 years, 4 months ago (2013-08-26 02:09:07 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/22852029/3001

7 years, 4 months ago (2013-08-26 02:09:16 UTC) #4

Message was sent while issue was closed.

Change committed as 156684

Expand Messages | Collapse Messages