|
We should never allow reprojecting the inside of author shadows, except when they're
being projected between ShadowRoots of the same type. This breaks all the tests that
were testing what happens if we allowed ShadowRoot on form controls and reproject
the inside of the form control, but we don't actually plan to ship that feature anyway.
I removed all the tests that can't be made into ref tests easily since the result is
a strangely busted form control and updated the other tests to show the behavior
when you add a ShadowRoot to something with author shadows.
This behavior was blocking landing a patch to remove fixPlaceholderRenderer
https://codereview.chromium.org/23035007/ which was further blocking making everything
lazyAttach.
BUG= 234020, 253801, 276689
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156668
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+29 lines, -477 lines) |
Patch |
 |
M |
LayoutTests/TestExpectations
|
View
|
1
2
|
2 chunks |
+0 lines, -11 lines |
0 comments
|
Download
|
 |
D |
LayoutTests/fast/dom/shadow/input-with-validation.html
|
View
|
|
1 chunk |
+0 lines, -25 lines |
0 comments
|
Download
|
 |
D |
LayoutTests/fast/dom/shadow/input-with-validation-expected.html
|
View
|
|
1 chunk |
+0 lines, -20 lines |
0 comments
|
Download
|
 |
D |
LayoutTests/fast/dom/shadow/shadowdom-for-fieldset-complex-shadow.html
|
View
|
1
2
|
1 chunk |
+0 lines, -16 lines |
0 comments
|
Download
|
 |
D |
LayoutTests/fast/dom/shadow/shadowdom-for-fieldset-complex-shadow-expected.html
|
View
|
1
2
|
1 chunk |
+0 lines, -11 lines |
0 comments
|
Download
|
 |
D |
LayoutTests/fast/dom/shadow/shadowdom-for-fieldset-only-shadow.html
|
View
|
1
2
|
1 chunk |
+0 lines, -19 lines |
0 comments
|
Download
|
 |
D |
LayoutTests/fast/dom/shadow/shadowdom-for-fieldset-only-shadow-expected.html
|
View
|
1
2
|
1 chunk |
+0 lines, -10 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/fast/dom/shadow/shadowdom-for-form-associated-element-useragent-expected.txt
|
View
|
1
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
D |
LayoutTests/fast/dom/shadow/shadowdom-for-input-button.html
|
View
|
|
1 chunk |
+0 lines, -54 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/fast/dom/shadow/shadowdom-for-input-button-click-expected.txt
|
View
|
1
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
D |
LayoutTests/fast/dom/shadow/shadowdom-for-input-button-expected.html
|
View
|
|
1 chunk |
+0 lines, -38 lines |
0 comments
|
Download
|
 |
D |
LayoutTests/fast/dom/shadow/shadowdom-for-keygen-complex-shadow.html
|
View
|
|
1 chunk |
+0 lines, -16 lines |
0 comments
|
Download
|
 |
D |
LayoutTests/fast/dom/shadow/shadowdom-for-keygen-complex-shadow-expected.html
|
View
|
|
1 chunk |
+0 lines, -9 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/fast/dom/shadow/shadowdom-for-media-expected.txt
|
View
|
1
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/fast/dom/shadow/shadowdom-for-meter-dynamic-expected.html
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
LayoutTests/fast/dom/shadow/shadowdom-for-meter-expected.html
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
LayoutTests/fast/dom/shadow/shadowdom-for-meter-multiple-expected.html
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
LayoutTests/fast/dom/shadow/shadowdom-for-meter-with-style-expected.html
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
LayoutTests/fast/dom/shadow/shadowdom-for-meter-without-appearance-expected.html
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
D |
LayoutTests/fast/dom/shadow/shadowdom-for-object-complex-shadow.html
|
View
|
1
2
|
1 chunk |
+0 lines, -15 lines |
0 comments
|
Download
|
 |
D |
LayoutTests/fast/dom/shadow/shadowdom-for-object-complex-shadow-expected.html
|
View
|
1
2
|
1 chunk |
+0 lines, -9 lines |
0 comments
|
Download
|
 |
D |
LayoutTests/fast/dom/shadow/shadowdom-for-object-without-shadow.html
|
View
|
1
2
|
1 chunk |
+0 lines, -12 lines |
0 comments
|
Download
|
 |
D |
LayoutTests/fast/dom/shadow/shadowdom-for-object-without-shadow-expected.html
|
View
|
1
2
|
1 chunk |
+0 lines, -7 lines |
0 comments
|
Download
|
 |
D |
LayoutTests/fast/dom/shadow/shadowdom-for-output-only-shadow.html
|
View
|
1
2
|
1 chunk |
+0 lines, -13 lines |
0 comments
|
Download
|
 |
D |
LayoutTests/fast/dom/shadow/shadowdom-for-output-only-shadow-expected.html
|
View
|
1
2
|
1 chunk |
+0 lines, -7 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/fast/dom/shadow/shadowdom-for-progress-dynamic-expected.html
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
LayoutTests/fast/dom/shadow/shadowdom-for-progress-expected.html
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
LayoutTests/fast/dom/shadow/shadowdom-for-progress-multiple-expected.html
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
LayoutTests/fast/dom/shadow/shadowdom-for-progress-with-style-expected.html
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
LayoutTests/fast/dom/shadow/shadowdom-for-progress-without-appearance-expected.html
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
D |
LayoutTests/fast/dom/shadow/shadowdom-for-select-complex-shadow.html
|
View
|
1
2
|
1 chunk |
+0 lines, -17 lines |
0 comments
|
Download
|
 |
D |
LayoutTests/fast/dom/shadow/shadowdom-for-select-complex-shadow-expected.html
|
View
|
1
2
|
1 chunk |
+0 lines, -9 lines |
0 comments
|
Download
|
 |
D |
LayoutTests/fast/dom/shadow/shadowdom-for-select-without-shadow.html
|
View
|
1
2
|
1 chunk |
+0 lines, -16 lines |
0 comments
|
Download
|
 |
D |
LayoutTests/fast/dom/shadow/shadowdom-for-select-without-shadow-expected.html
|
View
|
1
2
|
1 chunk |
+0 lines, -7 lines |
0 comments
|
Download
|
 |
D |
LayoutTests/fast/dom/shadow/shadowdom-for-textarea.html
|
View
|
|
1 chunk |
+0 lines, -21 lines |
0 comments
|
Download
|
 |
D |
LayoutTests/fast/dom/shadow/shadowdom-for-textarea-complex-shadow.html
|
View
|
1
2
3
|
1 chunk |
+0 lines, -36 lines |
0 comments
|
Download
|
 |
D |
LayoutTests/fast/dom/shadow/shadowdom-for-textarea-complex-shadow-expected.html
|
View
|
1
2
3
|
1 chunk |
+0 lines, -29 lines |
0 comments
|
Download
|
 |
D |
LayoutTests/fast/dom/shadow/shadowdom-for-textarea-expected.html
|
View
|
|
1 chunk |
+0 lines, -12 lines |
0 comments
|
Download
|
 |
M |
Source/core/dom/Element.h
|
View
|
1
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
Source/core/dom/Element.cpp
|
View
|
1
|
1 chunk |
+0 lines, -5 lines |
0 comments
|
Download
|
 |
M |
Source/core/dom/shadow/ElementShadow.cpp
|
View
|
1
|
1 chunk |
+7 lines, -5 lines |
0 comments
|
Download
|
 |
M |
Source/core/html/HTMLDetailsElement.h
|
View
|
1
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
Source/core/html/HTMLSummaryElement.h
|
View
|
1
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
Source/core/html/shadow/HTMLShadowElement.h
|
View
|
1
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
Source/core/html/shadow/HTMLShadowElement.cpp
|
View
|
|
1 chunk |
+7 lines, -14 lines |
0 comments
|
Download
|
Total messages: 10 (0 generated)
|