Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 22852020: Only allow reprojecting shadows between ShadowRoots of the same type (Closed)

Created:
7 years, 4 months ago by esprehn
Modified:
7 years, 4 months ago
CC:
blink-reviews, webcomponents-bugzilla_chromium.org, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org
Visibility:
Public.

Description

We should never allow reprojecting the inside of author shadows, except when they're being projected between ShadowRoots of the same type. This breaks all the tests that were testing what happens if we allowed ShadowRoot on form controls and reproject the inside of the form control, but we don't actually plan to ship that feature anyway. I removed all the tests that can't be made into ref tests easily since the result is a strangely busted form control and updated the other tests to show the behavior when you add a ShadowRoot to something with author shadows. This behavior was blocking landing a patch to remove fixPlaceholderRenderer https://codereview.chromium.org/23035007/ which was further blocking making everything lazyAttach. BUG=234020, 253801, 276689 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156668

Patch Set 1 #

Patch Set 2 : Rebaseline tests and add missing files, weird rietveld fail to upload #

Patch Set 3 : Remove more tests and fix TestExpectations #

Patch Set 4 : Delete another test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -477 lines) Patch
M LayoutTests/TestExpectations View 1 2 2 chunks +0 lines, -11 lines 0 comments Download
D LayoutTests/fast/dom/shadow/input-with-validation.html View 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/fast/dom/shadow/input-with-validation-expected.html View 1 chunk +0 lines, -20 lines 0 comments Download
D LayoutTests/fast/dom/shadow/shadowdom-for-fieldset-complex-shadow.html View 1 2 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/fast/dom/shadow/shadowdom-for-fieldset-complex-shadow-expected.html View 1 2 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/fast/dom/shadow/shadowdom-for-fieldset-only-shadow.html View 1 2 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/fast/dom/shadow/shadowdom-for-fieldset-only-shadow-expected.html View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
M LayoutTests/fast/dom/shadow/shadowdom-for-form-associated-element-useragent-expected.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
D LayoutTests/fast/dom/shadow/shadowdom-for-input-button.html View 1 chunk +0 lines, -54 lines 0 comments Download
M LayoutTests/fast/dom/shadow/shadowdom-for-input-button-click-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
D LayoutTests/fast/dom/shadow/shadowdom-for-input-button-expected.html View 1 chunk +0 lines, -38 lines 0 comments Download
D LayoutTests/fast/dom/shadow/shadowdom-for-keygen-complex-shadow.html View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/fast/dom/shadow/shadowdom-for-keygen-complex-shadow-expected.html View 1 chunk +0 lines, -9 lines 0 comments Download
M LayoutTests/fast/dom/shadow/shadowdom-for-media-expected.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/shadowdom-for-meter-dynamic-expected.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/shadow/shadowdom-for-meter-expected.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/shadow/shadowdom-for-meter-multiple-expected.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/shadow/shadowdom-for-meter-with-style-expected.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/shadow/shadowdom-for-meter-without-appearance-expected.html View 1 chunk +1 line, -1 line 0 comments Download
D LayoutTests/fast/dom/shadow/shadowdom-for-object-complex-shadow.html View 1 2 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/fast/dom/shadow/shadowdom-for-object-complex-shadow-expected.html View 1 2 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/fast/dom/shadow/shadowdom-for-object-without-shadow.html View 1 2 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/fast/dom/shadow/shadowdom-for-object-without-shadow-expected.html View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/fast/dom/shadow/shadowdom-for-output-only-shadow.html View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/fast/dom/shadow/shadowdom-for-output-only-shadow-expected.html View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M LayoutTests/fast/dom/shadow/shadowdom-for-progress-dynamic-expected.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/shadow/shadowdom-for-progress-expected.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/shadow/shadowdom-for-progress-multiple-expected.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/shadow/shadowdom-for-progress-with-style-expected.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/shadow/shadowdom-for-progress-without-appearance-expected.html View 1 chunk +1 line, -1 line 0 comments Download
D LayoutTests/fast/dom/shadow/shadowdom-for-select-complex-shadow.html View 1 2 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/fast/dom/shadow/shadowdom-for-select-complex-shadow-expected.html View 1 2 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/fast/dom/shadow/shadowdom-for-select-without-shadow.html View 1 2 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/fast/dom/shadow/shadowdom-for-select-without-shadow-expected.html View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/fast/dom/shadow/shadowdom-for-textarea.html View 1 chunk +0 lines, -21 lines 0 comments Download
D LayoutTests/fast/dom/shadow/shadowdom-for-textarea-complex-shadow.html View 1 2 3 1 chunk +0 lines, -36 lines 0 comments Download
D LayoutTests/fast/dom/shadow/shadowdom-for-textarea-complex-shadow-expected.html View 1 2 3 1 chunk +0 lines, -29 lines 0 comments Download
D LayoutTests/fast/dom/shadow/shadowdom-for-textarea-expected.html View 1 chunk +0 lines, -12 lines 0 comments Download
M Source/core/dom/Element.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/Element.cpp View 1 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/dom/shadow/ElementShadow.cpp View 1 1 chunk +7 lines, -5 lines 0 comments Download
M Source/core/html/HTMLDetailsElement.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLSummaryElement.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/shadow/HTMLShadowElement.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/shadow/HTMLShadowElement.cpp View 1 chunk +7 lines, -14 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
esprehn
7 years, 4 months ago (2013-08-23 01:24:17 UTC) #1
hayato
Just in curious, could the older shadow root of the UA's shadow root be an ...
7 years, 4 months ago (2013-08-23 04:17:58 UTC) #2
esprehn
On 2013/08/23 04:17:58, hayato wrote: > Just in curious, could the older shadow root of ...
7 years, 4 months ago (2013-08-23 04:28:31 UTC) #3
hayato
LGTM I am afraid that I haven't followed the recent discussion on BUG=234020. From the ...
7 years, 4 months ago (2013-08-23 05:35:06 UTC) #4
esprehn
On 2013/08/23 05:35:06, hayato wrote: > LGTM > > I am afraid that I haven't ...
7 years, 4 months ago (2013-08-23 19:49:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/22852020/8001
7 years, 4 months ago (2013-08-23 20:31:48 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=3026
7 years, 4 months ago (2013-08-23 22:35:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/22852020/21001
7 years, 4 months ago (2013-08-24 00:12:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/22852020/31001
7 years, 4 months ago (2013-08-24 01:39:21 UTC) #9
commit-bot: I haz the power
7 years, 4 months ago (2013-08-24 02:55:50 UTC) #10
Message was sent while issue was closed.
Change committed as 156668

Powered by Google App Engine
This is Rietveld 408576698