Issue 22849026: WebCrypto: Check for HmacKeyParams when seeing if a Key can be used for an Algorithm.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22849026: WebCrypto: Check for HmacKeyParams when seeing if a Key can be used for an Algorithm. (Closed)

Created:
7 years, 4 months ago by eroman

Modified:
7 years, 4 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

WebCrypto: Check for HmacKeyParams when seeing if a Key can be used for an Algorithm. The testing of HMAC equivalance was broken by r156343, since keys made by generateKey() would have a different parameter type. This change: (1) Fixes the above bug (2) Refactors the code to live in Key.cpp rather than SubtleCrypto.cpp (since the latter is already large). (3) Adds a more descriptive message to the exception thrown when keys don't match. BUG=245025 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156498

Patch Set 1 #

Patch Set 2 : Rebase onto master #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+94 lines, -61 lines)			Patch
M	LayoutTests/crypto/encrypt-decrypt-expected.txt	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	LayoutTests/crypto/sign-verify.html	View	2 chunks	+13 lines, -4 lines	0 comments	Download
M	LayoutTests/crypto/sign-verify-expected.txt	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	Source/modules/crypto/Key.h	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	Source/modules/crypto/Key.cpp	View	3 chunks	+71 lines, -0 lines	0 comments	Download
M	Source/modules/crypto/SubtleCrypto.cpp	View	3 chunks	+2 lines, -54 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/22849026/5001

7 years, 4 months ago (2013-08-21 19:26:48 UTC) #3

Message was sent while issue was closed.

Change committed as 156498

Expand Messages | Collapse Messages