Issue 22848003: Resubmit issue to fix issue where window bounds were being passed with

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22848003: Resubmit issue to fix issue where window bounds were being passed with (Closed)

Created:
7 years, 4 months ago by zturner

Modified:
7 years, 4 months ago

Reviewers:
sky

CC:
chromium-reviews, jbauman+watch_chromium.org, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, miu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Resubmit issue to fix issue where window bounds were being passed with wrong coordinates. This is a speculative re-upload as the previous change was reverted with mysterious failures which seemed unrelated to my change. It has been more than 1 week, and being unable to find any reason for the failures, will try again with the same commit to see if the issues resurface. Original review URL: https://codereview.chromium.org/19681003/ BUG=176221 TBR=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218338

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+140 lines, -57 lines)			Patch
M	content/browser/renderer_host/render_widget_host_impl.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_aura.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_aura.cc	View	3 chunks	+64 lines, -56 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_aura_unittest.cc	View	3 chunks	+71 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zturner@chromium.org/22848003/1

7 years, 4 months ago (2013-08-19 17:52:54 UTC) #2

Message was sent while issue was closed.

Change committed as 218338

Expand Messages | Collapse Messages