Fix for crash occuring when spatial navigation is enabled

Fix for crash occuring when spatial navigation is enabled
and user tries to navigate from the element containing shadow DOM
such as <input type="date">.

BUG=234034
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156839

[Krzysztof Olczyk, 2013-08-12 14:19:32]

Hi Hayato, Tkent, Morrita,

this is a small fix for a crash which occurs e.g. while navigating out of a date
box when spatial navigation is enabled.
This also seems to be a small step in fixing
http://code.google.com/p/chromium/issues/detail?id=234034

Could you please take a look at it?

[tkent, 2013-08-13 23:09:56]

https://codereview.chromium.org/22847002/diff/1/LayoutTests/fast/spatial-navi...
File LayoutTests/fast/spatial-navigation/snav-date.html (right):

https://codereview.chromium.org/22847002/diff/1/LayoutTests/fast/spatial-navi...
LayoutTests/fast/spatial-navigation/snav-date.html:5: <script
src="js/resources/js-test-post.js"></script>
looks a wrong path.

https://codereview.chromium.org/22847002/diff/1/LayoutTests/fast/spatial-navi...
LayoutTests/fast/spatial-navigation/snav-date.html:20: description('This test
ensures the correctness of Spatial Navigation (SNav) algorithm over date input
element (having shadow DOM).<br>\
All of lines in the <script> content has leading 4-space indentation.  It's
annoying.

https://codereview.chromium.org/22847002/diff/1/LayoutTests/fast/spatial-navi...
LayoutTests/fast/spatial-navigation/snav-date.html:22: 1) DRT support for SNav
enable/disable.<br>\
We don't have DRT any longer.

https://codereview.chromium.org/22847002/diff/1/LayoutTests/fast/spatial-navi...
LayoutTests/fast/spatial-navigation/snav-date.html:29: ["Left", "left"],
We usually use 4-space indentation in JavaScript code.

https://codereview.chromium.org/22847002/diff/1/LayoutTests/fast/spatial-navi...
LayoutTests/fast/spatial-navigation/snav-date.html:39: testRunner.dumpAsText();
You don't need to call this because js-test-pre.js does it.

https://codereview.chromium.org/22847002/diff/1/LayoutTests/fast/spatial-navi...
LayoutTests/fast/spatial-navigation/snav-date.html:56: testRunner.notifyDone();
We should use jsTestIsAsync=true + finishJSTest().

[Krzysztof Olczyk, 2013-08-23 12:03:16]

Updated layout tests according to review comments.

https://codereview.chromium.org/22847002/diff/1/LayoutTests/fast/spatial-navi...
File LayoutTests/fast/spatial-navigation/snav-date.html (right):

https://codereview.chromium.org/22847002/diff/1/LayoutTests/fast/spatial-navi...
LayoutTests/fast/spatial-navigation/snav-date.html:5: <script
src="js/resources/js-test-post.js"></script>
On 2013/08/13 23:09:56, tkent wrote:
> looks a wrong path.

Done.

https://codereview.chromium.org/22847002/diff/1/LayoutTests/fast/spatial-navi...
LayoutTests/fast/spatial-navigation/snav-date.html:20: description('This test
ensures the correctness of Spatial Navigation (SNav) algorithm over date input
element (having shadow DOM).<br>\
On 2013/08/13 23:09:56, tkent wrote:
> All of lines in the <script> content has leading 4-space indentation.  It's
> annoying.
> 

Done.

https://codereview.chromium.org/22847002/diff/1/LayoutTests/fast/spatial-navi...
LayoutTests/fast/spatial-navigation/snav-date.html:22: 1) DRT support for SNav
enable/disable.<br>\
On 2013/08/13 23:09:56, tkent wrote:
> We don't have DRT any longer.
> 

Done.

https://codereview.chromium.org/22847002/diff/1/LayoutTests/fast/spatial-navi...
LayoutTests/fast/spatial-navigation/snav-date.html:29: ["Left", "left"],
On 2013/08/13 23:09:56, tkent wrote:
> We usually use 4-space indentation in JavaScript code.

Done.

https://codereview.chromium.org/22847002/diff/1/LayoutTests/fast/spatial-navi...
LayoutTests/fast/spatial-navigation/snav-date.html:39: testRunner.dumpAsText();
On 2013/08/13 23:09:56, tkent wrote:
> You don't need to call this because js-test-pre.js does it.

Done.

https://codereview.chromium.org/22847002/diff/1/LayoutTests/fast/spatial-navi...
LayoutTests/fast/spatial-navigation/snav-date.html:56: testRunner.notifyDone();
On 2013/08/13 23:09:56, tkent wrote:
> We should use jsTestIsAsync=true + finishJSTest().

Done.

[tkent, 2013-08-25 22:11:36]

https://codereview.chromium.org/22847002/diff/6001/LayoutTests/fast/spatial-n...
File LayoutTests/fast/spatial-navigation/snav-date.html (right):

https://codereview.chromium.org/22847002/diff/6001/LayoutTests/fast/spatial-n...
LayoutTests/fast/spatial-navigation/snav-date.html:6: window.jsTestIsAsync =
true;
Do not indent all of <script> content equally.  Also, I don't think we need to
indent HTML tags.  I mean we had better do:

<!DOCTYPE html>
<head>
<script ..>
<script ...>
<script>
window.jsTestIsAsync = true;
if (window.testRunner) {
    testRunner.overridePreference(...)
    ....
</script>

https://codereview.chromium.org/22847002/diff/6001/LayoutTests/fast/spatial-n...
LayoutTests/fast/spatial-navigation/snav-date.html:9:
testRunner.overridePreference("WebKitTabToLinksPreferenceKey", 1);
We usually use 4-space indentation in JavaScript code.

https://codereview.chromium.org/22847002/diff/6001/LayoutTests/fast/spatial-n...
LayoutTests/fast/spatial-navigation/snav-date.html:28: description('This test
ensures the correctness of Spatial Navigation (SNav) algorithm over date input
element (having shadow DOM).<br>\
Ditto for indentation.

https://codereview.chromium.org/22847002/diff/6001/LayoutTests/fast/spatial-n...
LayoutTests/fast/spatial-navigation/snav-date.html:48: initTest(resultMap,
testCompleted);
testCompleted function is redundant.  You can do
  initTest(rsultMap, finishJSTest);

[Krzysztof Olczyk, 2013-08-28 08:13:00]

https://codereview.chromium.org/22847002/diff/6001/LayoutTests/fast/spatial-n...
File LayoutTests/fast/spatial-navigation/snav-date.html (right):

https://codereview.chromium.org/22847002/diff/6001/LayoutTests/fast/spatial-n...
LayoutTests/fast/spatial-navigation/snav-date.html:6: window.jsTestIsAsync =
true;
On 2013/08/25 22:11:36, tkent wrote:
> Do not indent all of <script> content equally.  Also, I don't think we need to
> indent HTML tags.  I mean we had better do:
> 
> <!DOCTYPE html>
> <head>
> <script ..>
> <script ...>
> <script>
> window.jsTestIsAsync = true;
> if (window.testRunner) {
>     testRunner.overridePreference(...)
>     ....
> </script>

Done.

https://codereview.chromium.org/22847002/diff/6001/LayoutTests/fast/spatial-n...
LayoutTests/fast/spatial-navigation/snav-date.html:9:
testRunner.overridePreference("WebKitTabToLinksPreferenceKey", 1);
On 2013/08/25 22:11:36, tkent wrote:
> We usually use 4-space indentation in JavaScript code.
> 

Done.

https://codereview.chromium.org/22847002/diff/6001/LayoutTests/fast/spatial-n...
LayoutTests/fast/spatial-navigation/snav-date.html:28: description('This test
ensures the correctness of Spatial Navigation (SNav) algorithm over date input
element (having shadow DOM).<br>\
On 2013/08/25 22:11:36, tkent wrote:
> Ditto for indentation.

Done.

https://codereview.chromium.org/22847002/diff/6001/LayoutTests/fast/spatial-n...
LayoutTests/fast/spatial-navigation/snav-date.html:48: initTest(resultMap,
testCompleted);
On 2013/08/25 22:11:36, tkent wrote:
> testCompleted function is redundant.  You can do
>   initTest(rsultMap, finishJSTest);

Done.

[tkent, 2013-08-28 09:16:21]

lgtm

[commit-bot: I haz the power, 2013-08-28 09:20:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kolczyk@opera.com/22847002/14001

[commit-bot: I haz the power, 2013-08-28 10:58:15]

Change committed as 156839