Source/core/rendering/RenderImage.cpp - Issue 22839023: Add support for the object-position CSS property.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderImage.cpp

Issue 22839023: Add support for the object-position CSS property. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase master Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/RenderImage.cpp

diff --git a/Source/core/rendering/RenderImage.cpp b/Source/core/rendering/RenderImage.cpp

index e622c9c11317792966e7f71abf6e04e1b55f2bdd..8a2c63775e4dd2ad008ce5c12544385ffb0da329 100644

--- a/Source/core/rendering/RenderImage.cpp

+++ b/Source/core/rendering/RenderImage.cpp

@@ -517,6 +517,9 @@ bool RenderImage::foregroundIsKnownToBeOpaqueInRect(const LayoutRect& localRect,

// Background shows in padding area.

if ((backgroundClip == BorderFillBox || backgroundClip == PaddingFillBox) && style()->hasPadding())

return false;

+ // Object-position may leave parts of the content box empty, regardless of the value of object-fit.

+ if (style()->objectPosition() != RenderStyle::initialObjectPosition())

+ return false;

// Object-fit may leave parts of the content box empty.

ObjectFit objectFit = style()->objectFit();

if (objectFit != ObjectFitFill && objectFit != ObjectFitCover)

« no previous file with comments | « Source/core/platform/LengthPoint.h ('k') | Source/core/rendering/RenderReplaced.cpp » ('j') | no next file with comments »