Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 22839006: [android_webview] Implement requestChildRectangleOnScreen. (Closed)

Created:
7 years, 4 months ago by mkosiba (inactive)
Modified:
7 years, 4 months ago
Reviewers:
joth, benm (inactive)
CC:
chromium-reviews, android-webview-reviews_chromium.org
Visibility:
Public.

Description

[android_webview] Implement requestChildRectangleOnScreen. This implements the AwContents.requestChildRectangleOnScreen method. BUG=272744 TEST=AndroidWebViewTest NOTRY=true Java-only CL, ran through trybots. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218265

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -7 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 1 chunk +9 lines, -0 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwScrollOffsetManager.java View 1 2 chunks +63 lines, -0 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwScrollOffsetManagerTest.java View 5 chunks +110 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mkosiba (inactive)
PTAL
7 years, 4 months ago (2013-08-16 12:20:58 UTC) #1
joth
lgtm
7 years, 4 months ago (2013-08-16 21:27:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkosiba@chromium.org/22839006/3001
7 years, 4 months ago (2013-08-19 10:57:07 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-08-19 10:57:22 UTC) #4
Message was sent while issue was closed.
Change committed as 218265

Powered by Google App Engine
This is Rietveld 408576698