Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Unified Diff: chrome/browser/sessions/persistent_tab_restore_service_browsertest.cc

Issue 22837005: Add HTTP status code to navigation data structures (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix bug Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sessions/persistent_tab_restore_service_browsertest.cc
diff --git a/chrome/browser/sessions/persistent_tab_restore_service_browsertest.cc b/chrome/browser/sessions/persistent_tab_restore_service_browsertest.cc
index 8dfb56b4f3dd3781a2d1dcee87c316e5d697b2f8..4c2d3d925acd68e257c6380b375ba7c7482e29e7 100644
--- a/chrome/browser/sessions/persistent_tab_restore_service_browsertest.cc
+++ b/chrome/browser/sessions/persistent_tab_restore_service_browsertest.cc
@@ -624,6 +624,50 @@ TEST_F(PersistentTabRestoreServiceTest, TimestampSurvivesRestore) {
}
}
+// Makes sure we restore status codes correctly.
+TEST_F(PersistentTabRestoreServiceTest, StatusCodesSurviveRestore) {
+ AddThreeNavigations();
+
+ // Have the service record the tab.
+ service_->CreateHistoricalTab(web_contents(), -1);
+
+ // Make sure an entry was created.
+ ASSERT_EQ(1U, service_->entries().size());
+
+ // Make sure the entry matches.
+ std::vector<sessions::SerializedNavigationEntry> old_navigations;
+ {
+ // |entry|/|tab| doesn't survive after RecreateService().
+ TabRestoreService::Entry* entry = service_->entries().front();
+ ASSERT_EQ(TabRestoreService::TAB, entry->type);
+ Tab* tab = static_cast<Tab*>(entry);
+ old_navigations = tab->navigations;
+ }
+
+ EXPECT_EQ(3U, old_navigations.size());
+ for (size_t i = 0; i < old_navigations.size(); ++i) {
+ EXPECT_EQ(200, old_navigations[i].http_status_code());
+ }
+
+ // Set this, otherwise previous session won't be loaded.
+ profile()->set_last_session_exited_cleanly(false);
+
+ RecreateService();
+
+ // One entry should be created.
+ ASSERT_EQ(1U, service_->entries().size());
+
+ // And verify the entry.
+ TabRestoreService::Entry* restored_entry = service_->entries().front();
+ ASSERT_EQ(TabRestoreService::TAB, restored_entry->type);
+ Tab* restored_tab =
+ static_cast<Tab*>(restored_entry);
+ ASSERT_EQ(old_navigations.size(), restored_tab->navigations.size());
+ for (size_t i = 0; i < restored_tab->navigations.size(); ++i) {
+ EXPECT_EQ(200, restored_tab->navigations[i].http_status_code());
+ }
+}
+
TEST_F(PersistentTabRestoreServiceTest, PruneEntries) {
service_->ClearEntries();
ASSERT_TRUE(service_->entries().empty());
« no previous file with comments | « android_webview/native/state_serializer_unittests.cc ('k') | chrome/browser/sessions/session_restore_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698