Issue 22837002: Fix error in Shill to ONC translation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22837002: Fix error in Shill to ONC translation. (Closed)

Created:
7 years, 4 months ago by pneubeck (no reviews)

Modified:
7 years, 4 months ago

Reviewers:
bartfab (slow)

CC:
chromium-reviews, gauravsh+watch_chromium.org, gspencer+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix error in Shill to ONC translation. Since the addition of CA certificate PEMs, the test of the Shill to ONC translation of OpenVPN networks logged an error. This commit fixes this error and adds another test of the Shill to ONC translation of WiFi with EAP. BUG=NONE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217095

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -9 lines)			Patch
M	chromeos/network/onc/onc_translator_shill_to_onc.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chromeos/network/onc/onc_translator_unittest.cc	View	1 chunk	+10 lines, -8 lines	0 comments	Download
M	chromeos/test/data/network/translation_of_shill_openvpn.onc	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	chromeos/test/data/network/translation_of_shill_wifi_clientcert.onc	View	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

pneubeck (no reviews)

Bartosz, please take a quick look. This doesn't affect production code.

7 years, 4 months ago (2013-08-12 13:25:32 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/22837002/1

7 years, 4 months ago (2013-08-12 18:37:49 UTC) #3

Message was sent while issue was closed.

Change committed as 217095

Expand Messages | Collapse Messages