Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(899)

Issue 22831043: KeyboardEvent.location should be DOM_KEY_LOCATION_STANDARD for Num Lock key (Closed)

Created:
7 years, 4 months ago by do-not-use
Modified:
7 years, 3 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, Masayuki Nakano (Mozilla Japan
Visibility:
Public.

Description

KeyboardEvent.location should be DOM_KEY_LOCATION_STANDARD for Num Lock key KeyboardEvent.location should be DOM_KEY_LOCATION_STANDARD for Num Lock key. This behavior is consistent with IE and Firefox. However, Blink returns DOM_KEY_LOCATION_NUMPAD for it on Windows (the value is correct on Mac and Linux). This patch fixes Blink on Windows to be inline with the others. BUG=263724 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156693

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove mention of DRT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -1 line) Patch
A LayoutTests/fast/events/keydown-numlock-standard-location.html View 1 1 chunk +46 lines, -0 lines 0 comments Download
A LayoutTests/fast/events/keydown-numlock-standard-location-expected.txt View 1 chunk +13 lines, -0 lines 0 comments Download
M Source/testing/runner/EventSender.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/testing/runner/KeyCodeMapping.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/testing/runner/KeyCodeMapping.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/web/win/WebInputEventFactory.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
do-not-use
7 years, 4 months ago (2013-08-23 20:08:49 UTC) #1
arv (Not doing code reviews)
LGTM
7 years, 4 months ago (2013-08-23 20:36:16 UTC) #2
tkent
lgtm https://codereview.chromium.org/22831043/diff/1/LayoutTests/fast/events/keydown-numlock-standard-location.html File LayoutTests/fast/events/keydown-numlock-standard-location.html (right): https://codereview.chromium.org/22831043/diff/1/LayoutTests/fast/events/keydown-numlock-standard-location.html#newcode40 LayoutTests/fast/events/keydown-numlock-standard-location.html:40: debug("This test requires DumpRenderTree."); nit: No DRT any ...
7 years, 4 months ago (2013-08-25 22:29:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/22831043/10001
7 years, 4 months ago (2013-08-26 05:51:55 UTC) #4
commit-bot: I haz the power
Change committed as 156693
7 years, 4 months ago (2013-08-26 06:59:43 UTC) #5
Wez
+garykac@, who should probably have been reviewer for this CL. :) As per the DOM ...
7 years, 3 months ago (2013-08-27 01:41:45 UTC) #6
garykac
On 2013/08/27 01:41:45, Wez wrote: > +garykac@, who should probably have been reviewer for this ...
7 years, 3 months ago (2013-08-27 02:15:02 UTC) #7
masayuki_d-toybox.com
I guess the reason is, NumLock key may not be a part of Numpad. E.g., ...
7 years, 3 months ago (2013-08-27 13:20:24 UTC) #8
Wez
7 years, 3 months ago (2013-08-27 20:55:43 UTC) #9
OK, SGTM


On 27 August 2013 06:20, Masayuki Nakano <masayuki@d-toybox.com> wrote:

> I guess the reason is, NumLock key may not be a part of Numpad. E.g., on
> notebook's keyboard, the key location depends on its OEM vendor.
>
>
> On 2013/08/27 11:15, garykac@chromium.org wrote:
>
>> On 2013/08/27 01:41:45, Wez wrote:
>>
>>> +garykac@, who should probably have been reviewer for this CL. :)
>>>
>>
>>  As per the DOM Level 3 Events specification, keys on the numeric pad
>>> should be
>>> reported with location DOM_KEY_LOCATION_NUMPAD - since NumLock is on the
>>>
>> numeric
>>
>>> keypad, it should also use that value.
>>>
>>
>> My interpretation of DOM_KEY_LOCATION_STANDARD is that it is supposed to
>> be used
>> whenever the key occurs only once on the keyboard.
>>
>> The non-STANDARD locations: _LEFT, _RIGHT, _NUMPAD are only used when
>> the key
>> occurs multiple times on the keyboard.
>>
>> However, with the way the spec is written, it sounds like NumLock should
>> have a
>> location of DOM_KEY_LOCATION_NUMPAD:
>>     "The key activation originated on the numeric keypad or with a
>> virtual key
>> corresponding to the numeric keypad".
>>
>> Since this can go either way *and* all the other browsers already
>> implement this
>> as location = STANDARD, I'll update the spec to be clear about the
>> location of
>> the NumLock key (and I'll confirm the intent with the other
>> editors/www-dom
>> people).
>>
>>
>>
https://chromiumcodereview.**appspot.com/22831043/<https://chromiumcodereview...
>>
>
>
> --
> Masayuki Nakano <masayuki@d-toybox.com>
> Manager, Internationalization, Mozilla Japan.
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698