Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 22831006: In LabelButton::SetIsDefault: ~ is bitwise NOT, not !. (Closed)

Created:
7 years, 4 months ago by jbroman
Modified:
7 years, 4 months ago
Reviewers:
sadrul
CC:
chromium-reviews, tfarina, danakj
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

In LabelButton::SetIsDefault: ~ is bitwise NOT, not !. As described in http://www.viva64.com/en/b/0205/. BUG=271533 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217149

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/views/controls/button/label_button.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jbroman
7 years, 4 months ago (2013-08-12 19:03:51 UTC) #1
sadrul
LGTM
7 years, 4 months ago (2013-08-12 19:06:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/22831006/1
7 years, 4 months ago (2013-08-12 19:12:24 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-08-13 01:15:23 UTC) #4
Message was sent while issue was closed. 
Change committed as 217149

Powered by Google App Engine
This is Rietveld 408576698