Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5299)

Unified Diff: chrome/browser/ui/views/location_bar/page_info_helper.cc

Issue 22831005: Use visible entry for website settings dialog. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix TabSpecificContentSettings Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/gtk/location_bar_view_gtk.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/location_bar/page_info_helper.cc
diff --git a/chrome/browser/ui/views/location_bar/page_info_helper.cc b/chrome/browser/ui/views/location_bar/page_info_helper.cc
index 7f27d50ebcd2a6b4e9bbd5d93eeecc09101dc3c6..48391224a2d740aa855c4cce8d929b01fe856e2c 100644
--- a/chrome/browser/ui/views/location_bar/page_info_helper.cc
+++ b/chrome/browser/ui/views/location_bar/page_info_helper.cc
@@ -34,7 +34,8 @@ void PageInfoHelper::ProcessEvent(const ui::LocatedEvent& event) {
if (!tab)
return;
const NavigationController& controller = tab->GetController();
- NavigationEntry* nav_entry = controller.GetActiveEntry();
+ // Important to use GetVisibleEntry to match what's showing in the omnibox.
+ NavigationEntry* nav_entry = controller.GetVisibleEntry();
if (!nav_entry) {
NOTREACHED();
return;
« no previous file with comments | « chrome/browser/ui/gtk/location_bar_view_gtk.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698